Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-12337: Add KServe Logger TLS bundle support #311

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ruivieira
Copy link
Member

Refer to RHOAIENG-12337.

This PR adds support for KServe's InferenceLogger TLS CA bundles.

If a KServe InferenceService is deployed in the same namespace as the TrustyAIService, the operator will:

  • Check the configured CA bundle for logging in the global KServe inferenceservice-config CM.
  • If the there isn't a CA bundle defined, the operator will add a non-TLS logger to the IS (i.e. http://...)
  • If there is a CA bundle defined:
    • If it is already present in the namespace, will be mounted at /etc/tls/kserve on the service and specified with the env var KSERVE_LOGGER_CA_CERT
    • If there is no CA bundle CM defined, it will be created by operator (using OpenShift Serving Certificates) with CM name and CA name as in the global KServe config and mounted on the service as above
    • A TLS logger URL will be created (i.e. https://...)

@ruivieira ruivieira added the kind/enhancement New feature or request label Oct 7, 2024
@ruivieira ruivieira self-assigned this Oct 7, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 7, 2024

@ruivieira: This pull request references RHOAIENG-12337 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Refer to RHOAIENG-12337.

This PR adds support for KServe's InferenceLogger TLS CA bundles.

If a KServe InferenceService is deployed in the same namespace as the TrustyAIService, the operator will:

  • Check the configured CA bundle for logging in the global KServe inferenceservice-config CM.
  • If the there isn't a CA bundle defined, the operator will add a non-TLS logger to the IS (i.e. http://...)
  • If there is a CA bundle defined:
  • If it is already present in the namespace, will be mounted at /etc/tls/kserve on the service and specified with the env var KSERVE_LOGGER_CA_CERT
  • If there is no CA bundle CM defined, it will be created by operator (using OpenShift Serving Certificates) with CM name and CA name as in the global KServe config and mounted on the service as above
  • A TLS logger URL will be created (i.e. https://...)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Oct 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants