Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMP sample update #4150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KMP sample update #4150

wants to merge 1 commit into from

Conversation

vsima
Copy link

@vsima vsima commented Dec 5, 2024

Updates

  • android sdk 35 & ios 18
  • kotlin 2.1.0
  • gradle 8.10
  • AGP 8.7

@vsima
KMP sample update
4610ba4 
 - android sdk 35 & ios 18
 - kotlin 2.1.0
 - gradle 8.10
 - AGP 8.7
@satoshiotomakan
Copy link
Collaborator

Hi @Elyniss, do you have a chance to take a look at the PR?

@vsima
Copy link
Author

vsima commented Dec 5, 2024

@satoshiotomakan @Elyniss
Here's the working screencapture
Screenshot 2024-12-05 at 8 50 23 AM

@Elyniss
Copy link

Elyniss commented Dec 9, 2024

@vsima Out of curiosity, why kmp samples need to be updated? Is this just keeping them up to date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ar-g ar-g Awaiting requested review from ar-g

@JaimeToca JaimeToca Awaiting requested review from JaimeToca JaimeToca is a code owner

@rkokhatskyi rkokhatskyi Awaiting requested review from rkokhatskyi rkokhatskyi is a code owner

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

@satoshiotomakan satoshiotomakan Awaiting requested review from satoshiotomakan satoshiotomakan is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsima @satoshiotomakan @Elyniss