Fix request data logging for httprb/http version 4

[tycooon]

Since version 3, httprb/http gem logs request data like this:
[httplog] Data: #<HTTP::Request::Body:0x00007ffa7e32ccd0>

Unfortunately, it's difficult to make version 3 work, but in version 4 (currently in development and only available in master) they added HTTP::Request::Body#source, so we can do stuff like source.to_s and source.rewind. This patch fixes cases for plaintext body and form body types. Note that we are just using to_s on source so that file bodies are going to be logged like #<File:0x00007ffabb2ba620> which I think is OK because we don't want to read the whole file.

Travis is not configured to test different gem versions for this repo, but I tested the patch locally and all specs pass if you add gem "http", github: "httprb/http" to the Gemfile (one spec fails if you update http gem to version 3).

[trusche]

Aweseome, thanks @tycooon . I'll try to get that merged as soon as possible, need to figure out the Travis config.

[tycooon]

I think I know how to make this work in version 3, but this is going to use instance_variable_get. What do you think?
And I also know how to configure travis to test different httprb versions, do you want me to add it to this PR?

[trusche]

That would be great!

…

On 14 Feb 2018 13:30, "Yuri Smirnov" ***@***.***> wrote: I think I now how to make this work in version 3, but this is going to use instance_variable_get. What do you think? And I also know how to configure travis to test different httprb versions, do you want me to add it to this PR? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#56 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHR1oktkWOhrcmmy-AiN0flwZoxXABYks5tUt_WgaJpZM4SFFH1> .

[tycooon]

Done, please take a look.

[trusche]

I published v1.0.1 with this. Thanks again!