-
Notifications
You must be signed in to change notification settings - Fork 682
fix: storage value encoding in forked trie. #658
Conversation
Hey @davidmurdoch @seesemichaelj I took the liberty of implementing the fix myself, as it wasn't that big! Do let me know if any changes are needed. |
Thanks for the PR! I'll defer to @davidmurdoch on this one. @nebojsa94 any chance you could add a test that demonstrates it's broken before the fix and fixed after it? |
Done @seesemichaelj, @davidmurdoch let me know if any other changes need to be made |
Hey @davidmurdoch, I wanted to check if we could help out in any way to push this forward? 😄 |
@BogdanHabic Ah, sorry I dropped the ball on this! I'll review this today! |
I just wanted to say that I ran into a similar issue (reading back contract after write in same call not correct), and this patch fixed it. |
This PR resolves #625
It extends the ethereumjs-util rlp encoding by forcing the removal of any leading zeros.