Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: set networkId on forked raw transactions #566

Merged
merged 1 commit into from
Apr 21, 2020
Merged

fix: set networkId on forked raw transactions #566

merged 1 commit into from
Apr 21, 2020

Conversation

davidmurdoch
Copy link
Member

Fixes #706

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 82.2% when pulling 6249df1 on fix/forked-signed-transactions into a5f43a4 on develop.

nicholasjpaterno
nicholasjpaterno approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@nicholasjpaterno nicholasjpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@davidmurdoch davidmurdoch merged commit d8c65b6 into develop Apr 21, 2020
@davidmurdoch davidmurdoch deleted the fix/forked-signed-transactions branch September 30, 2020 16:16
@Woodpile37 Woodpile37 mentioned this pull request Aug 18, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicholasjpaterno nicholasjpaterno nicholasjpaterno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ganache CLI 6.8.1] eth_sendRawTransaction Not Working For Signed Transactions
3 participants
@davidmurdoch @coveralls @nicholasjpaterno