Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix:slow tests sometimes timeout #537

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fix:slow tests sometimes timeout #537

merged 1 commit into from
Jan 20, 2020

Conversation

davidmurdoch
Copy link
Member

No description provided.

Copy link
Contributor

@nicholasjpaterno nicholasjpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (where the exclamation mark means not 😂 )

✔️

I'm adding a todo to follow up with web3 about this issue.

@@ -1,3 +1,4 @@
const memdown = require("memdown");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

await send("evm_mine");
// web3 doesn't subscribe fast enough to newHeads after issuing the previous send
// we we mine another block to give it an additional newHeads notification. /shrug
await send("evm_mine");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ 🤷‍♂️

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.076% when pulling 6646c71 on fix/slow-test into 4cf4338 on develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants