Update blockchain_double.js to properly hex encode Log without leading zeroes #103
Conversation
|
nevermind, looks like #73 accomplished this with a different approach? |
|
looks like issue still persists even with #73 for some endpoints? |
lib/utils/txhelper.js
Outdated
| gasPrice: to.hex(tx.gasPrice), | ||
| input: to.hex(tx.data), | ||
| hash: to.rpcDataHexString(tx.hash()), | ||
| nonce: to.rpcDataHexString(tx.nonce), |
There was a problem hiding this comment.
Nonce should be a quantity string per https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_gettransactionbyhash
|
I think this needs to be rebased on current develop. Also if you could please add tests for the fields you've changed that would be ideal. |
|
I'm going to move this to our backlog to do what @benjamincburns asked a month ago as we can complete the requested changes. I think this may be related to #166 If you feel the desire to complete this @nickysemenza and no one assigns themselves to this PR, please make a comment and we'll let you make the changes. Thanks! |
mikeseese
added
priority4 📋
correctness/consistency
priority2 ⚠️
and removed
awaiting response
priority4 📋
labels
benjamincburns
force-pushed
the
patch-1
branch
from
cf0f354 to
0c16bcb
Compare
|
I've just gone ahead and rebased this on current |
When trying to talk to
ganache-clioverRPC from go-ethereum:cannot unmarshal hex number with leading zero digits into Go struct field Log.logIndex of type hexutil.UintThis was based off of changes I observed in #92