exposed AzureOpenAI provider #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I should create docs for this too. I'll work on that. |
|
Thanks @epinzur ! |
epinzur
commented
Dec 19, 2023
| @@ -366,26 +366,25 @@ class AzureOpenAI(OpenAI): | |||
| Has the same functionality as OpenAI out of the box feedback functions. | |||
| """ | |||
|
|
|||
| def __init__(self, endpoint=None, deployment_name="gpt-35-turbo", **kwargs): | |||
| def __init__(self, deployment_name: str, endpoint=None, **kwargs): | |||
There was a problem hiding this comment.
I dropped the default here since model deployment names in Azure can be anything. I can deploy gpt-3.5-turbo as open-ai.
There was a problem hiding this comment.
Is there a typical default that we can still use?
There was a problem hiding this comment.
I don't think so. There are no models deployed by default. You need to pick and choose which to deploy and choose the name at deployment time. The deployment name often doesn't match the model name due to Azure naming restrictions.
|
I've tested this locally by copying the AzureOpenAI class into my notebook. |
joshreini1
approved these changes
Dec 20, 2023
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jun 28, 2024
* exposed AzureOpenAI provider * added docs * Update CONTRIBUTING.md * typo in mkdocs.yml --------- Co-authored-by: Josh Reini <[email protected]>
sfc-gh-chu
pushed a commit
that referenced
this pull request
Sep 25, 2024
* exposed AzureOpenAI provider * added docs * Update CONTRIBUTING.md * typo in mkdocs.yml --------- Co-authored-by: Josh Reini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed the AzureOpenAI provider so I can use it to power feedback functions.