Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of some context manager stuff and better handling of GetItemOrAttribute. #1687

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-dkurokawa
Copy link
Contributor

@sfc-gh-dkurokawa sfc-gh-dkurokawa commented Dec 6, 2024

Description

Minor cleanup of some context manager stuff and better handling of GetItemOrAttribute.

Other details good to know for developers

This is kinda a mish-mash of some stuff, but is just some more stuff I'm pulling from Piotr's PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

Important

Improves context manager exception handling and refines GetItemOrAttribute logic, with minor docstring formatting changes.

  • Context Manager Handling:
    • In app.py, __exit__ and __aexit__ methods now return False to not suppress exceptions.
  • GetItemOrAttribute Handling:
    • In serial.py, GetItemOrAttribute.get() now checks for __getitem__ instead of Dict.
  • Docstring Formatting:
    • Minor formatting changes in docstrings in base.py.

This description was created by Ellipsis for 9acf807. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants