Minor cleanup of some context manager stuff and better handling of GetItemOrAttribute
.
#1687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor cleanup of some context manager stuff and better handling of
GetItemOrAttribute
.Other details good to know for developers
This is kinda a mish-mash of some stuff, but is just some more stuff I'm pulling from Piotr's PR.
Type of change
not work as expected)
Important
Improves context manager exception handling and refines
GetItemOrAttribute
logic, with minor docstring formatting changes.app.py
,__exit__
and__aexit__
methods now returnFalse
to not suppress exceptions.serial.py
,GetItemOrAttribute.get()
now checks for__getitem__
instead ofDict
.base.py
.This description was created by for 9acf807. It will automatically update as commits are pushed.