span database #1608
Open
span database #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| class DB(serial_utils.SerialModel, abc.ABC, text_utils.WithIdentString): | ||
| """Abstract definition of databases used by trulens. | ||
|
|
||
| [SQLAlchemyDB][trulens.core.database.sqlalchemy.SQLAlchemyDB] is the main | ||
| and default implementation of this interface. | ||
| """ | ||
|
|
||
| T: ClassVar[Type] = Any |
There was a problem hiding this comment.
Consider using more specific types instead of Type for T, Q, and W to improve type safety and clarity. This comment applies to lines 106, 109, and 112.
Suggested change
| T: ClassVar[Type] = Any | |
| T: ClassVar[SpecificType] = Any |
| before_created_timestamp: builtins.NoneType | ||
| before_index: builtins.NoneType | ||
| before_updated_timestamp: builtins.NoneType | ||
| limit: builtins.NoneType |
There was a problem hiding this comment.
Consider initializing limit and offset with integer values instead of NoneType to avoid potential issues in calculations or queries.
Suggested change
| limit: builtins.NoneType | |
| limit: builtins.int |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
trulens-semconvpackage to hold tracing attribute names and related. This package intentionally has no dependencies other than otel semconv packages.Adds span schema as orm classes and span to/of orm methods.
Adds span "semantic categories" for known components like retrievers.
Adds span extensions to db base abstract class and the sqlalchemy implementation for inserting, selecting, deleting spans.
Adds some prototype abstractions to base DB class for pagination and queries.
Extended
trulens.core.schema.typeswith classes organizing types for values we use across python, otel, and sql.- Recognizing spans into the semantic categories not included (but the categories exist). Will bring this in from an old PR next.
- Feedback evaluation not included.
- Collector not included (though started in this PR).
Other details good to know for developers
Please include any other details of this change useful for TruLens developers.
Type of change
not work as expected)
Important
Introduces
trulens-semconvfor tracing attributes, adds span schema and database methods, and organizes types across Python, OTEL, and SQL.trulens-semconvpackage for tracing attribute names.SpanAttributesandSpanTypeintrace.pyfor span categorization.trulens.core.schema.typesfor organizing types across Python, OTEL, and SQL.pyproject.tomlto includetrulens-semconvpackage.This description was created by
for 812dfc2. It will automatically update as commits are pushed.