Run streamlit dashboard on docker container #1571
Conversation
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d853b10 in 32 seconds
More details
- Looked at
357lines of code in7files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/dashboard/trulens/dashboard/streamlit_utils.py:61
- Draft comment:
Storing passwords directly in the code is a security risk. Consider using environment variables or a secure vault to manage sensitive information. - Reason this comment was not posted:
Marked as duplicate.
2. tools/snowflake/spcs_dashboard/Dockerfile:8
- Draft comment:
Combine thepip installcommands into a single RUN statement to reduce the number of layers in the Docker image and improve build performance.
RUN pip install -r requirements.txt \
&& pip install trulens_connectors_snowflake-1.0.1-py3-none-any.whl \
&& pip install trulens_dashboard-1.0.1-py3-none-any.whl
- Reason this comment was not posted:
Confidence changes required:50%
The Dockerfile should be optimized to reduce the number of layers and improve build performance.
Workflow ID: wflow_OnhmyXvTHxR6XD30
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| db_url = URL( | ||
| account=snowpark_session.get_current_account(), | ||
| user=snowpark_session.get_current_user(), | ||
| password="password", |
There was a problem hiding this comment.
Storing passwords directly in the code is a security risk. Consider using environment variables or a secure vault to manage sensitive information.
| session = Session.builder.configs(connection_parameters).create() | ||
|
|
||
| # Create compute pool if it does not exist | ||
| compute_pool_name = input("Enter compute pool name: ") |
There was a problem hiding this comment.
Using input() for getting the compute pool name is not suitable for automated scripts or production environments. Consider using environment variables or command-line arguments instead.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 272a194 in 13 seconds
More details
- Looked at
33lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/dashboard/trulens/dashboard/streamlit.py:68
- Draft comment:
The import statement forosis repeated. Consider moving it to the top with other imports to avoid redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The import statement for 'os' is repeated within the 'if args.spcs_runtime:' block. It should be moved to the top with other imports to avoid redundancy.
2. src/dashboard/trulens/dashboard/streamlit.py:40
- Draft comment:
Unnecessary blank line after function definition. Remove for better readability. This applies to line 47 as well. - Reason this comment was not posted:
Confidence changes required:10%
There is an unnecessary blank line after the function definitionsget_spcs_login_tokenandinit_from_args. These should be removed for better code readability.
Workflow ID: wflow_LdspBlL0Ine8c6an
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| RUN pip install trulens_connectors_snowflake-1.0.1-py3-none-any.whl | ||
| RUN pip install trulens_dashboard-1.0.1-py3-none-any.whl |
There was a problem hiding this comment.
This is temporary, once the next version of trulens is released, then this can go in requirments.
There was a problem hiding this comment.
Check with corey whether requirements.txt can be done using poetry instead.
|
I'm not familiar enough with the snowflake setup to check most of this PR. One generic comment about the python: if possible, can anything snowflake related be separated into different files? |
Description
Please include a summary of the changes and the related issue that can be
included in the release announcement. Please also include relevant motivation
and context.
Other details good to know for developers
Please include any other details of this change useful for TruLens developers.
Type of change
not work as expected)
Important
Add Docker setup and Snowflake integration for Streamlit dashboard with
spcs_runtimesupport.Dockerfileto build a container for Streamlit dashboard.requirements.txtfor dependencies.run_container.pyandrun_dashboard.pyfor configuring and running the dashboard.hostparameter toSnowflakeConnectorinconnector.py.spcs_runtimeoption torun_dashboard()inrun.py.init_from_args()instreamlit.pyto handlespcs_runtimeand Snowflake token-based authentication.This description was created by
for 272a194. It will automatically update as commits are pushed.