Fix caps to expected caps for LangChain provider (and to match docs) #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
removed
the
size:XS
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
the
size:L
sfc-gh-chu
reviewed
Sep 18, 2024
| @@ -36,8 +36,8 @@ any { | |||
| `from trulens_eval import Huggingface as $alias` => `from trulens.providers.huggingface.provider import Huggingface as $alias`, | |||
| `from trulens_eval import HuggingfaceLocal` => `from trulens.providers.huggingface.provider import HuggingfaceLocal`, | |||
| `from trulens_eval import HuggingfaceLocal as $alias` => `from trulens.providers.huggingface.provider import HuggingfaceLocal as $alias`, | |||
| `from trulens_eval import Langchain` => `from trulens.providers.langchain.provider import Langchain`, | |||
There was a problem hiding this comment.
Can we change these? I thought this is referencing the old trulens_eval API?
| @@ -9,4 +9,4 @@ | |||
|
|
|||
| deprecation_utils.packages_dep_warn() | |||
|
|
|||
| from trulens.providers.langchain.provider import Langchain | |||
There was a problem hiding this comment.
may need to alias for compatability
from trulens.... import LangChain as Langchain
| @@ -1,6 +1,6 @@ | |||
| trulens_eval: | |||
| __class__: builtins.module | |||
| __version__: 0.33.0 | |||
| __version__: 1.0.0.a | |||
There was a problem hiding this comment.
these are expected to stay static. We need to update src/trulens_eval to match the <1.0 spec though. See note above about aliasing the import
| @@ -9,7 +9,7 @@ trulens_eval: | |||
| FeedbackMode: enum.EnumType | |||
| Huggingface: pydantic._internal._model_construction.ModelMetaclass | |||
| HuggingfaceLocal: pydantic._internal._model_construction.ModelMetaclass | |||
| Langchain: pydantic._internal._model_construction.ModelMetaclass | |||
There was a problem hiding this comment.
Will need to revert these as well
| @@ -37,7 +37,7 @@ def setUp(self): | |||
| "Provider", | |||
| "AzureOpenAI", | |||
| "OpenAI", | |||
| "Langchain", | |||
| @@ -44,7 +44,7 @@ | |||
| with imports_utils.OptionalImports( | |||
| messages=optional_utils.REQUIREMENT_PROVIDER_LANGCHAIN | |||
| ): | |||
| from trulens.providers.langchain.provider import Langchain | |||
| from trulens.providers.langchain.provider import LangChain | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix caps to expected caps for LangChain provider (and to match docs). Identified in #1454
Other details good to know for developers
Please include any other details of this change useful for TruLens developers.
Type of change
not work as expected)