Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have Makefile upload target should first build packages. #1366

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Have Makefile upload target should first build packages. #1366

merged 1 commit into from
Aug 21, 2024

Conversation

sfc-gh-dkurokawa
Copy link
Contributor

Description

Have Makefile upload target should first build packages.

Other details good to know for developers

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 20, 2024
sfc-gh-pdharmana
sfc-gh-pdharmana approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-pdharmana sfc-gh-pdharmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tq

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2024
@sfc-gh-dkurokawa sfc-gh-dkurokawa merged commit 5ef53d9 into main Aug 21, 2024
7 checks passed
@sfc-gh-dkurokawa sfc-gh-dkurokawa deleted the davidkurokawa/clean_up_Makefile_upload branch August 21, 2024 05:52
sfc-gh-pdharmana pushed a commit that referenced this pull request Aug 21, 2024
@sfc-gh-dkurokawa @sfc-gh-pdharmana
Clean up Makefile upload target. (#1366)
d671545
sfc-gh-chu pushed a commit that referenced this pull request Sep 25, 2024
@sfc-gh-dkurokawa
Clean up Makefile upload target. (#1366)
9a53c72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pmardziel sfc-gh-pmardziel sfc-gh-pmardziel approved these changes

@sfc-gh-pdharmana sfc-gh-pdharmana sfc-gh-pdharmana approved these changes

@sfc-gh-chu sfc-gh-chu sfc-gh-chu approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-dkurokawa @sfc-gh-chu @sfc-gh-pdharmana @sfc-gh-pmardziel