-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] otel-like recording #1168
Draft
piotrm0
wants to merge
39
commits into
main
Choose a base branch
from
piotrm/record_as_spans
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
May 31, 2024
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
* working on trace-like recording * don't recall * traces notebook work * cost tracking adjustments --------- Co-authored-by: Piotr Mardziel <[email protected]>
sfc-gh-pmardziel
force-pushed
the
piotrm/record_as_spans
branch
from
July 1, 2024 18:32
9a0c94f
to
49a3170
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work has moved to another PR: #1346 . Keeping this around until the new PR is merged.
Other details that are good to know but need not be announced:
Record
s from spans collected in the process of executing a recording context. These records are available in the recording context as before and sent to the same places as before (i.e. to database, for feedback evaluation).Tru
class argumentotel_exporter
to specify where to export spans. If specified, the spans that make up a record will be exported there whenever a record is created (upon recording context closure).ComponentView
and related code as that is not being used and is being replaced by spans in the feature/traces work.trulens_eval.instruments
(for tracing) and intrulens_eval.feedback.provider.endpoint.base
(for cost tracking) into a common solution found in a new utility moduletrulens_eval.utils.wrap
.EndpointCallback
used for cost tracking to extent the generalized callable wrapping callbacks found in the newwrap
module.