Remove placeholder feedback for asynchronous responses #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
@piotrm0 why were we writing a placeholder before? Is there some reason we're overlooking why this is necessary? |
This message was added to let a user know that if they used some (langchain/other) method that was asynchronous and they didn't await it, their feedbacks might not run properly. |
joshreini1
approved these changes
May 7, 2024
Was the issue related to |
|
The issue still persists on the latest code in #1110 Screenshot: |
piotrm0
added a commit
that referenced
this pull request
May 29, 2024
* Remove references to running moderation endpoint on AzureOpenAI (#1116) * azureopenai docstring * azureopenai.md * remove extra references to supported feedbacks * Update azureopenai.md * swap rag utility (qs)relevance (#1120) * add otel semantic convention attributes * notes * Fix Link (#1128) * update groundedness prompt (#1112) Co-authored-by: Josh Reini <[email protected]> * Fix docs links in instrumentation (#1129) * fix link on langchain instrumentation docs * fix llama-index quickstart link * fix langchain instrumentation docs, add missing imports * add missing imports to nemo instrumentation docs * fix rag triad and awaitable calls (#1110) * fix rag triad and awaitable calls * remove locals printout in awaitables message * add otel spec note * extending custom tool to store the call stack for demonstration purposes, added trulens internals demonstrations notebook * trurails: update to getattr (#1130) * fix rag triad and awaitable calls * remove locals printout in awaitables message * update __getattr__ in select_context (#1119) --------- Co-authored-by: Piotr Mardziel <[email protected]> * Remove placeholder feedback (#1127) Co-authored-by: Josh Reini <[email protected]> * Default names for rag triad utility (#1122) * Update feedback.py * use name * add reasons to answer, context relevance; add collect to groundedness * Update custom functions notebook to reflect context relevance change (#1134) * Update custom_feedback_functions.ipynb * Update README.md (#1136) retreivers -> retrievers * revert original spans, leave otel versions for future use * formatting * move temporary things into another file * Unify groundedness interface (#1135) * unify groundedness start * remove groundedness.py * groundedness nli moves * remove custom aggregator * groundedness aggregator to user code * move agg to trulens side by default (groundedness) * remove extra code * remove hf key setting * remove hf import * add comment about aggregation for context relevance * update init * remove unneeded import * use generate_score_and_reasons for groundedness internally * f-strings for groundedness prompts * docstring * docstrings formatting * groundedness reasons template * remove redundant prompt * update quickstarts * llama-index notebooks * rag triad helper update * oai assistant nb * update readme * models notebooks updates * iterate nbs * mongo, pinecone nbs * update huggingface docstring * remove outdated docstring selector notes * more docstring cleaning * checkpoint tracing testing * dont iterate streams in openai cost tracking (#1138) * open ai streaming adjustments in cost tracking * notes * delete outputs * Automated File Generation from Docs Notebook Changes (#1137) Co-authored-by: joshreini1 <[email protected]> Co-authored-by: Josh Reini <[email protected]> * Fix a few old groundedness references (#1139) * Update selecting_components.md * Update MultiQueryRetrievalLangchain.ipynb * Update random_evaluation.ipynb * Update canopy_quickstart.ipynb * Update all_tools.py * Update llama_index_quickstart.ipynb * Automated File Generation from Docs Notebook Changes (#1141) Co-authored-by: joshreini1 <[email protected]> * rename and docs of temp file * add freeze/thaw for exporters/importers * update comprehensiveness + nb (#1064) * update comprehensiveness + nb * nb expansion * fix typo * meetingbank transcript data * oss models in app * test * benchmarking gpt-3.5-turbo, gpt-4-turbo, and gpt-4o * update path * comprehensiveness benchmark * updated summarization_eval nb * fix normalization * show improvement in comprehensiveness feedback functions --------- Co-authored-by: Daniel <[email protected]> * complexifying the example custom app * debugging * context nesting testing * 0.29.0 version bump (#1140) * version bump * simpler lc quickstart * update installs and imports * update langchain instrumentation docs * remove groundedness ref from providers.md * build docs fixes * remove key cell * fix docs build * firx formatting for stock.md * remove extra spaces * undo format change * update docstrings for hugs and base provider * openai docstring updates * hugs docstring update * update context relevance hugs docstring * more docstring updates * remove can be changed messages from openai provider docstrings * Automated File Generation from Docs Notebook Changes (#1143) Co-authored-by: joshreini1 <[email protected]> * glossary additions (#1144) * add to glossary * finish some terms * clean up notebook * split off contexts examples * move more things into context examples * fixing some instrumentation stuff to be more robust * prototyping json queries * Update ollama_quickstart.ipynb * don't remember * add deprecation message for old module attributes * adjust notes * Patch imports error (#1146) * add httpx to requirements * undo httpx add * test add langchain-community * change langchain-community required version * add langchain_community to optional imports and checks for use of openai endpoint (#1154) * first * adjust docs * logic * add langhain_community to pinecone reqs too * adjust trubot example with new reqs * more reqs * remove extra text * add langchain_community to a few imports in notebooks --------- Co-authored-by: Piotr Mardziel <[email protected]> Co-authored-by: Josh Reini <[email protected]> * 0.30.0 bump (#1158) Co-authored-by: Josh Reini <[email protected]> * 0.30.1 bump (#1159) Co-authored-by: Josh Reini <[email protected]> * update ref to groundedness fn (#1161) --------- Co-authored-by: Josh Reini <[email protected]> Co-authored-by: Tim Baumgärtner <[email protected]> Co-authored-by: Brian McGough <[email protected]> Co-authored-by: Aaron <[email protected]> Co-authored-by: Josh Reini <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: joshreini1 <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: Piotr Mardziel <[email protected]> Co-authored-by: Josh Reini <[email protected]>
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jun 28, 2024
Co-authored-by: Josh Reini <[email protected]>
sfc-gh-chu
pushed a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Josh Reini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other details that are good to know but need not be announced: