Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sendUpdate lock free #13986

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Sep 5, 2022

Ensure that only single thread
will execute sendUpdate

Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
please stress test that.

@sopel39 sopel39 force-pushed the ks/lock_free branch 4 times, most recently from fdeb75d to 4fb9a1f Compare September 5, 2022 09:08
Ensure that only single thread
will execute sendUpdate
@sopel39
Copy link
Member Author

sopel39 commented Sep 5, 2022

please stress test that.

will add one

@sopel39
Copy link
Member Author

sopel39 commented Sep 5, 2022

baseline: 8916 queries /h
lock-free branch: 10485 queries / h

@sopel39 sopel39 merged commit 33e4afe into trinodb:master Sep 5, 2022
@sopel39 sopel39 deleted the ks/lock_free branch September 5, 2022 19:54
@github-actions github-actions bot added this to the 395 milestone Sep 5, 2022
@sopel39 sopel39 mentioned this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants