Improve BenchmarkDecimalAggregation #13939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cases for small, big and mixed decimals, and for in order and random group ids to differentiate between normal and disabled aggregation cases. Add benchmarks for evaluate and deserialize to focus on decimal serializer performance.
lukasz-stec
added
performance
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add cases for small, big and mixed decimals,
and for in order and random group ids to
differentiate between normal and disabled aggregation cases.
Add benchmarks for evaluate and deserialize
to focus on decimal serializer performance.
improvement
core query engine benchmark (
BenchmarkDecimalAggregation)improve micro benchmark for decimal aggregation
Related issues, pull requests, and links
Documentation
( X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( X) No release notes entries required.
( ) Release notes entries required with the following suggested text: