Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Update or reset selection on value change in multiselect mode #2873

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Sep 19, 2024

Description

Fixes #2719 #2720

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit f9fe9ac
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66ec0bdf7005be000843898b
😎 Deploy Preview https://deploy-preview-2873--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 changed the title Autocomplete: reset value on multi select mode Autocomplete: update and reset value state on multi select mode Sep 19, 2024
@prashanthr6383 prashanthr6383 added the bug Something is wrong and needs to be addressed label Sep 19, 2024
@prashanth-offcl prashanth-offcl changed the title Autocomplete: update and reset value state on multi select mode Autocomplete: Update or Reset selection on value change in multiselect mode Sep 19, 2024
@prashanth-offcl prashanth-offcl changed the title Autocomplete: Update or Reset selection on value change in multiselect mode Autocomplete: Update or reset selection on value change in multiselect mode Sep 19, 2024
@prashanth-offcl prashanth-offcl merged commit 45db25b into main Sep 19, 2024
10 checks passed
@prashanth-offcl prashanth-offcl deleted the 2719---Autocomplete-Introduce-an-option-to-clear-the-chips-in-multiselect-mode branch September 19, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete: Introduce an option to clear the chips in multiselect mode
2 participants