Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Uneven width on row selection and row action column #1922

Open
2 tasks done
Akashmuthumanickam opened this issue Dec 1, 2023 · 5 comments · May be fixed by #2874
Open
2 tasks done

Table: Uneven width on row selection and row action column #1922

Akashmuthumanickam opened this issue Dec 1, 2023 · 5 comments · May be fixed by #2874
Assignees
@ElishaSamPeterPrabhu
Labels
2 2 story points bug Something is wrong and needs to be addressed division-cpd Created by users in the CPD division external-request Bugs and features reported by individuals from other teams in Trimble modus-table Modus Table component development priority:low Prioritization for this item is low team-cpd Tickets created by the CPD team members

Comments

@Akashmuthumanickam
Copy link

Prerequisites

Describe the issue

There is no fixed width on the row selection and row action column and unable to fix the custom width in the case of enabling full width.
@msankaran0712 @enowak1031 @rthanga1
image

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

High

What product/project are you using Modus Components for ?

Flux - Connect web extensions

What is your team/division name ?

CPD

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

No response
@Akashmuthumanickam Akashmuthumanickam added the bug Something is wrong and needs to be addressed label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Hello @Akashmuthumanickam! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Dec 1, 2023
@rthanga1
Copy link
Contributor

@rthanga1 To talk to Muthu and understand the issue better

@rthanga1 rthanga1 self-assigned this Dec 18, 2023
@Akashmuthumanickam
Copy link
Author

Hi @rthanga1,
We can discuss this and any associated tickets that I have submitted.

@rthanga1
Copy link
Contributor

Even when the flexi-width option is provided, the checkbox and the action column should not take up so much space

@rthanga1 rthanga1 removed their assignment Dec 19, 2023
@rthanga1 rthanga1 added priority:low Prioritization for this item is low team-cpd Tickets created by the CPD team members division-cpd Created by users in the CPD division labels Dec 19, 2023
@rthanga1 rthanga1 moved this from In Review to To Do in Modus Web Components Dec 19, 2023
@rthanga1 rthanga1 moved this from To Do to Refinement in Modus Web Components Dec 19, 2023
@rthanga1 rthanga1 added 1 1 story point and removed 1 1 story point labels Dec 19, 2023
@rthanga1 rthanga1 moved this from Refinement to To Do in Modus Web Components Dec 20, 2023
@rthanga1 rthanga1 added the 2 2 story points label Dec 20, 2023
@venkyn13 venkyn13 mentioned this issue Jan 11, 2024
Draft
13 tasks
@rthanga1 rthanga1 self-assigned this Jan 24, 2024
@rthanga1 rthanga1 moved this from To Do to PR Review in Modus Web Components Jan 24, 2024
@rthanga1 rthanga1 moved this from PR Review to In Progress in Modus Web Components Jan 24, 2024
@cjwinsor cjwinsor moved this from In Progress to Refinement in Modus Web Components Apr 18, 2024
@cjwinsor cjwinsor mentioned this issue May 3, 2024
Open
@cjwinsor
Copy link
Contributor

cjwinsor commented May 9, 2024

Tanstack table seems to set a default width even when we don't set a width to the column, causing this behavior. Is there a way to have tanstack table not default the width and what does it break if we do so? Resize?

@prashanth-offcl prashanth-offcl changed the title Modus table - Uneven width on row selection and row action column Table: Uneven width on row selection and row action column Aug 21, 2024
@prashanth-offcl prashanth-offcl added the modus-table Modus Table component development label Aug 21, 2024
This was referenced Aug 21, 2024
Closed
Open
Closed
@prashanth-offcl prashanth-offcl moved this from To Do to In Progress in Modus Web Components Sep 16, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Sep 19, 2024 that will close this issue
Draft
13 tasks
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Sep 19, 2024 that will close this issue
Table: Set fixed check box width , new prop for setting row action column width #2874
Draft
13 tasks
@prashanth-offcl prashanth-offcl moved this from In Progress to PR Review in Modus Web Components Sep 24, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu moved this from In Progress to In Review in Modus Web Components Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu

Labels
2 2 story points bug Something is wrong and needs to be addressed division-cpd Created by users in the CPD division external-request Bugs and features reported by individuals from other teams in Trimble modus-table Modus Table component development priority:low Prioritization for this item is low team-cpd Tickets created by the CPD team members
Projects
Modus Web Components
Status: In Review
Milestone
No milestone
6 participants
@cjwinsor @rthanga1 @Akashmuthumanickam @prashanth-offcl @ElishaSamPeterPrabhu @prashanthr6383