Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modus Table: Fixed uneven width on rowSelection and rowAction columns #2014

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

venkyn13
Copy link
Contributor

Description

  1. Fixed uneven width on rowSelection and rowAction columns by making it's width as 30px. This worked fine only after adding table-layout: fixed style.
  2. Please find below attached gif.
    Modus-Bug-UnevenWidth
  3. Still it not fine when i remove fullWidth and I am looking forward for few hints to fix this too

References #1922

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@venkyn13 venkyn13 requested review from coliff and a team as code owners January 11, 2024 05:36
Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for modus-webcomponents failed.

Name Link
🔨 Latest commit 0a0a7b0
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/659fb5dbb1c8b100081f2f5e

@coliff coliff changed the title Fixed uneven width on rowSelection and rowAction columns Modus Table: Fixed uneven width on rowSelection and rowAction columns Jan 11, 2024
@coliff
Copy link
Member

coliff commented Jan 11, 2024

Build failing:
image

@venkyn13
Copy link
Contributor Author

venkyn13 commented Jan 11, 2024

Build failing: image

@coliff
May i know, what may be the reason, I ran lint already, apart from style, I haven't touched any part

@coliff
Copy link
Member

coliff commented Jan 11, 2024

Build failing: image

@coliff May i know, what may be the reason, I ran lint already, apart from style, I haven't touched any part

npm run test (from stencil-workspace directory) runs the tests.

@coliff coliff marked this pull request as draft January 11, 2024 15:46
@venkyn13
Copy link
Contributor Author

@coliff
image

@coliff
Copy link
Member

coliff commented Jan 16, 2024

I'm not sure about that Puppeteer error. Check the Node version you have and use Node v16 if possible.
Also please squash commits in your PR if you can and fetch latest changes from main branch.

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for moduswebcomponents failed.

Name Link
🔨 Latest commit dd67b0d
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/65a77a7a492fdd0008c52750

@venkyn13
Copy link
Contributor Author

I'm not sure about that Puppeteer error. Check the Node version you have and use Node v16 if possible. Also please squash commits in your PR if you can and fetch latest changes from main branch.

Reverting to node v16 also didn't work

@rthanga1
Copy link
Contributor

I can run the tests and 3 tests are failing. I am looking at it now.

@rthanga1 rthanga1 requested a review from a team January 24, 2024 13:35
Copy link
Collaborator

@prashanth-offcl prashanth-offcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@venkyn13 We can sync up on a call to address the issue you are facing on your machine when you are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants