Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use 'transform' argument #115

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: Use 'transform' argument #115

merged 1 commit into from
Apr 18, 2024

Conversation

trevorld
Copy link
Owner

  • In {ggplot2} the trans argument was deprecated, uses transform instead

closes #113

@trevorld
Copy link
Owner Author

  • I guess naively swapping all trans with transform would technically be a breaking API change

  • We should either keep the trans for now and deprecate it or perhaps put a ... in our scale functions and pass it onto the underlying ggplot2 scales

    • This may lead to breaking changes if the ... is put where users are setting arguments positionally although the trans argument is near the back...

@trevorld
Copy link
Owner Author

trevorld commented Apr 18, 2024 •
edited
Loading

  • Force pushed an update that instead deprecates trans so there shouldn't be any breaking changes
  • Several continuous scales now gain a ... that can be passed to the underlying ggplot2::continuous_scale()
  • We know import {lifecycle} but since we import {ggplot2} which imports {lifecycle} this isn't a new net dependency

@trevorld
refactor: Deprecated 'trans' for new 'transform'
2725b42 
* In line with upstream changes in `{ggplot2}` the `trans` argument has been deprecated in various scales functions.
  Use the new `transform` argument instead (#113).
* Several (continuous) scales now have an `...` argument which will passed onto `ggplot2::continuous_scale()`.
* We now import {lifecycle} to help mark these deprecations but since
  {ggplot2} imports {lifecycle} and we import {ggplot2} this isn't a new de facto dependency.

closes #113
@trevorld trevorld merged commit e0fd453 into master Apr 18, 2024
2 checks passed
@trevorld trevorld deleted the issue113 branch April 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The trans argument of continuous_scale() is deprecated
1 participant
@trevorld