Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRAN NOTEs #106

Closed
Tracked by #104
trevorld opened this issue Dec 4, 2023 · 0 comments · Fixed by #103
Closed
Tracked by #104

Fix CRAN NOTEs #106

trevorld opened this issue Dec 4, 2023 · 0 comments · Fixed by #103
Assignees
@trevorld
Labels
bug Something isn't working

Comments

@trevorld
Copy link
Owner

trevorld commented Dec 4, 2023

CRAN automatic checking is reporting a new NOTE:

Result: NOTE
  checkRd: (-1) scale_pattern_alpha_continuous.Rd:24-45: Lost braces
      24 | if (require("ggplot2")) {

https://cran.r-project.org/web/checks/check_results_ggpattern.html

Looking at the code we seem to have a missing Roxygen @examples...

Note we have not received any e-mail from CRAN to fix ASAP so can probably wait for #104 .
@trevorld trevorld added the bug Something isn't working label Dec 4, 2023
@trevorld trevorld self-assigned this Dec 4, 2023
@trevorld trevorld changed the title New CRAN NOTE Fix CRAN NOTEs Dec 4, 2023
@trevorld trevorld mentioned this issue Dec 4, 2023
Closed
23 tasks
trevorld added a commit that referenced this issue Jan 23, 2024
@trevorld
fix(scale-pattern-alpha.R): Missing '@examples'
d7223fb 
fixes #106
@trevorld trevorld mentioned this issue Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorld trevorld

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: V1.1.1 trevorld/ggpattern
1 participant
@trevorld