Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build environment #1740

Merged
merged 2 commits into from
May 24, 2022
Merged

Conversation

ehaupt
Copy link
Contributor

@ehaupt ehaupt commented May 9, 2022

This fixes:
#1739

@yoyama yoyama self-requested a review May 24, 2022 05:33
@yoyama yoyama added this to the v0.10.5 milestone May 24, 2022
@yoyama yoyama added the bug label May 24, 2022
Proposal fix for another failure in docker build
@yoyama
Copy link
Contributor

yoyama commented May 24, 2022

@ehaupt Thank you for your contribution.

I tested your PR but I found another failure on docker-build.

#8 97.24 Hit:5 http://security.ubuntu.com/ubuntu bionic-security InRelease
#8 97.27 Hit:6 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
#8 97.43 Err:7 https://apt.postgresql.org/pub/repos/apt bionic-pgdg Release
#8 97.43   Certificate verification failed: The certificate is NOT trusted. The certificate chain uses expired certificate.  Could not handshake: Error in the certificate verification. [IP: 72.32.157.246 443]
#8 97.43 Hit:8 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
#8 97.64 Reading package lists...
#8 98.80 E: The repository 'https://apt.postgresql.org/pub/repos/apt bionic-pgdg Release' does not have a Release file.

So I added another fix to this PR.
https://github.com/treasure-data/digdag/pull/1740/files#diff-8c9324bfc3666c3f067d0c41e00233f89474c536b0db7491f961f4eac9a0a882R5
How about your thought ?
If you are ok, I will approve it.

@ehaupt
Copy link
Contributor Author

ehaupt commented May 24, 2022

At the time this issue was submitted the additional ca-bundle was not required. Looks like this has changed.

If you are ok, I will approve it.

Definitely. Thank you.

Copy link
Contributor

@yoyama yoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoyama yoyama merged commit 2057011 into treasure-data:master May 24, 2022
@ehaupt ehaupt deleted the dockerbuildfix branch May 24, 2022 08:19
@yoyama yoyama mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants