update kubernetes-client version to 5.12.1 #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoppii13
force-pushed
the
update-k8s-client-5-12-1
branch
from
e80a6ff to
271044b
Compare
|
LGTM. But it might be better to add some tests. |
kyoppii13
force-pushed
the
update-k8s-client-5-12-1
branch
from
94c32d1 to
1341fd2
Compare
kyoppii13
force-pushed
the
update-k8s-client-5-12-1
branch
from
1341fd2 to
77831d1
Compare
|
@yoyama |
|
@yoyama |
yoyama
reviewed
Jul 8, 2022
...ndards/src/test/java/io/digdag/standards/command/kubernetes/DefaultKubernetesClientTest.java
Outdated
Show resolved
Hide resolved
yoyama
reviewed
Jul 8, 2022
...ndards/src/test/java/io/digdag/standards/command/kubernetes/DefaultKubernetesClientTest.java
Outdated
Show resolved
Hide resolved
|
@kyoppii13 I left comments on minor things. Please check it. |
|
@yoyama |
yoyama
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of k8s client to 5.12.1.
The reason is as follows.
https://github.com/fabric8io/kubernetes-client
kubernetes-client migration document fromt 4.x to 5.x