-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to Typescript #1698
Migrating to Typescript #1698
Conversation
// because of the global type, this results in an eslint error (when it's not) | ||
type ConsoleConfig = { | ||
url: string; | ||
interface AuthItem { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts-standard did type
-> interface
type ConsoleConfig = { | ||
url: string; | ||
interface AuthItem { | ||
key: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts-standard removed trailing ,
;
in type definitions
@szyn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late to review this PR, it looks good to me.
I found that current
@szyn @yoyama
|
What this PR changes?
What I'm planning after this PR
any
orts-ignore
so that digdag-ui will become more reliableeslint-disable
so that digdag-ui will become more relieableFor reviewers, and for contributors who will come here from commit history
any
,ts-ignore
andeslint-disable
are not desired ones. Resolving them should be welcome