-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor end-to-end tests #410
Conversation
…ndow.myUppyID.state
This reverts commit 6c76b01.
Okay, this seems to be working now, one page that we can run 3 tests against, the page is served by a built-in thing in webdriberio, so we don’t need to run website and custom bootandkill script anymore. New tests and platforms can be gradually added. |
package.json
Outdated
@@ -108,7 +111,8 @@ | |||
"url-parse": "1.1.9", | |||
"whatwg-fetch": "2.0.3", | |||
"yo-yo": "1.4.0", | |||
"yo-yoify": "3.7.2" | |||
"yo-yoify": "3.7.2", | |||
"webdriverio": "^4.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a devDependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fixed, thanks.
yay, works on my machine too :D |
Awesome! Glad you that you managed to run it and it works 🎉
Great idea, done! |
please kindly ignore that I typed
enetoent
instead ofendtoend