Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor end-to-end tests #410

Merged
merged 18 commits into from
Nov 10, 2017
Merged

Refactor end-to-end tests #410

merged 18 commits into from
Nov 10, 2017

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Nov 6, 2017

please kindly ignore that I typed enetoent instead of endtoend

@arturi arturi requested a review from goto-bus-stop November 7, 2017 20:52
@arturi
Copy link
Contributor Author

arturi commented Nov 7, 2017

Okay, this seems to be working now, one page that we can run 3 tests against, the page is served by a built-in thing in webdriberio, so we don’t need to run website and custom bootandkill script anymore. New tests and platforms can be gradually added.

@arturi arturi requested a review from kvz November 8, 2017 01:39
@arturi arturi changed the title [WIP] Refactor end-to-end tests Refactor end-to-end tests Nov 8, 2017
package.json Outdated
@@ -108,7 +111,8 @@
"url-parse": "1.1.9",
"whatwg-fetch": "2.0.3",
"yo-yo": "1.4.0",
"yo-yoify": "3.7.2"
"yo-yoify": "3.7.2",
"webdriverio": "^4.8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a devDependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, fixed, thanks.

@goto-bus-stop
Copy link
Contributor

goto-bus-stop commented Nov 9, 2017

yay, works on my machine too :D
maybe include a blurb on how developers should set this up in https://github.com/transloadit/uppy/blob/master/website/src/guide/contributing.md? or we could just link to http://webdriver.io/guide.html somewhere. webdriverio doesn't give very clear errors when the selenium server is not running (just "connection refused", which makes sense, but not if you don't know that you need to run selenium 😛 )

@arturi
Copy link
Contributor Author

arturi commented Nov 9, 2017

yay, works on my machine too :D

Awesome! Glad you that you managed to run it and it works 🎉

maybe include a blurb on how developers should set this up

Great idea, done!

@arturi arturi merged commit 5b70cb5 into master Nov 10, 2017
@arturi arturi deleted the feature/refactor-enetoent-tests branch November 10, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants