Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove expose(app) from metrics-diff-port-uvicorn example #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gpkc
Copy link

@gpkc gpkc commented Dec 5, 2024

According to the README for the example:

Minimal example that shows usage of Prometheus client library and Prometheus FastAPI Instrumentator with FastAPI and Uvicorn where the /metrics endpoint is exposed on another port and not on the FastAPI app itself.

This suggests that the metrics should NOT be exposed in the app itself for this example. However, calling expose(app) will do exactly that. So we can just remove that call.

@gpkc gpkc changed the title Remove expose(app) from metrics-diff-port-uvicorn example docs: Remove expose(app) from metrics-diff-port-uvicorn example Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant