feat: Feature to add custom labels with metrics #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martian711
changed the title
trallnag
requested changes
Mar 12, 2024
| @@ -27,6 +27,7 @@ def __init__( | |||
| modified_handler: str, | |||
| modified_status: str, | |||
| modified_duration: float, | |||
| custom_labels: dict, | |||
There was a problem hiding this comment.
I prefer to not have this attribute in the Info class. It should only contain attributes that are relevant for the respective request / response pair.
It is sufficient if all metrics closures included with this package get it as an additional parameter.
|
In general I would be fine with merging this if requested changes are implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_labelsin https://pypi.org/project/prometheus-flask-exporter/Changes are welcome, please suggest if any.