Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to Make the Instrumentator more Accessible #133

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Refactoring to Make the Instrumentator more Accessible #133

wants to merge 5 commits into from

Conversation

lazyBisa
Copy link

@lazyBisa lazyBisa commented Apr 29, 2022 •
edited
Loading

  • FastAPI Middleware is exposed as standalone object to be mounted instead of mutating an existing app
  • FastAPI Router is exposed as standalone object to be included instead of mutating an existing app
  • Allow for specifying a CollectorRegistry other than the default REGISTRY or a MultiProcessCollector
  • Smoother configuration options on default metrics

Also fixes a problem where the prometheus middleware was stripping causes from exception.

@trallnag
Copy link
Owner

Hey @lazyBisa, sorry for taking so long to look at your PR. Is this still relevant? #139 has already been merged and it refactored the code quite a bit. It is now an ASGI middleware.

@trallnag trallnag marked this pull request as draft March 12, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazyBisa @trallnag @martin-hartmond-mw