Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install warning: prometheus-fastapi-instrumentator 5.4.0 requires fastapi==0.38.1, but you'll have fastapi 0.61.1 which is incompatible. #14

Closed
PaulFlanaganGenscape opened this issue Oct 22, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@PaulFlanaganGenscape
Copy link

Shouldn't it be >=0.38.1 in requirements in pyproject.toml
https://github.com/trallnag/prometheus-fastapi-instrumentator/blob/master/pyproject.toml#L17

See warning at end below

$ pip install -U fastapi
Collecting fastapi
  Using cached fastapi-0.61.1-py3-none-any.whl (48 kB)
Collecting pydantic<2.0.0,>=1.0.0
  Using cached pydantic-1.6.1-cp38-cp38-macosx_10_9_x86_64.whl (2.3 MB)
Collecting starlette==0.13.6
  Using cached starlette-0.13.6-py3-none-any.whl (59 kB)
Installing collected packages: pydantic, starlette, fastapi
  Attempting uninstall: pydantic
    Found existing installation: pydantic 0.32.2
    Uninstalling pydantic-0.32.2:
      Successfully uninstalled pydantic-0.32.2
  Attempting uninstall: starlette
    Found existing installation: starlette 0.12.8
    Uninstalling starlette-0.12.8:
      Successfully uninstalled starlette-0.12.8
  Attempting uninstall: fastapi
    Found existing installation: fastapi 0.38.1
    Uninstalling fastapi-0.38.1:
      Successfully uninstalled fastapi-0.38.1
ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.

prometheus-fastapi-instrumentator 5.4.0 requires fastapi==0.38.1, but you'll have fastapi 0.61.1 which is incompatible.
Successfully installed fastapi-0.61.1 pydantic-1.6.1 starlette-0.13.6
@trallnag
Copy link
Owner

trallnag commented Oct 22, 2020

Indeed, good catch. Give me a minute and I'll release a patch

trallnag pushed a commit that referenced this issue Oct 22, 2020
Regression / mistake introduced in 5.4.0 and noticed and raised
by @PaulFlanaganGenscape here:

#14
@trallnag trallnag added the bug Something isn't working label Oct 22, 2020
@trallnag trallnag self-assigned this Oct 22, 2020
@trallnag
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants