Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/Add JEWEL logo #949

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Update/Add JEWEL logo #949

merged 2 commits into from
Dec 11, 2023

Conversation

MrZipper7
Copy link
Contributor

This PR:

  • Updates the existing logo for the old, deprecated version of the JEWEL token (0x4f60a160D8C2DDdaAfe16FCC57566dB84D674BD6)
  • Adds the logo for the new version of the JEWEL token (0x997Ddaa07d716995DE90577C123Db411584E5E46)

@cryptofish7
Copy link
Contributor

After merging #945, this has a merge conflict now - please resolve.

@MrZipper7
Copy link
Contributor Author

After merging #945, this has a merge conflict now - please resolve.

Will do. We'd gotten a request via TG to add a greyscale logo for the old token, but it looks like #945 removed the old version entirely. What's the preference? Have both and use greyscale on the old, or only include the new?

@cryptofish7
Copy link
Contributor

Didn't realise that. Preference would be to have greyscale of the old one please!

@MrZipper7
Copy link
Contributor Author

@cryptofish7 Should be good now. Thought the force would only impact my fork, but if this approach creates even more conflicts, I can just re-do it from scratch. Thanks!

cryptofish7
cryptofish7 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@cryptofish7 cryptofish7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptofish7 cryptofish7 merged commit 8246ab3 into traderjoe-xyz:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptofish7 cryptofish7 cryptofish7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrZipper7 @cryptofish7