-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix terminal size in tox commands (#2999) #3139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziima
force-pushed
the
2999-fix-terminal-size
branch
5 times, most recently
from
October 17, 2023 18:38
2e89382
to
508c581
Compare
ziima
force-pushed
the
2999-fix-terminal-size
branch
from
October 17, 2023 18:51
508c581
to
e91ad1c
Compare
PR is ready. |
descope bot
referenced
this pull request
in descope/django-descope
Dec 30, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | minor | `4.5.1` -> `4.11.4` | --- ### Release Notes <details> <summary>tox-dev/tox (tox)</summary> ### [`v4.11.4`](https://togithub.com/tox-dev/tox/releases/tag/4.11.4) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.11.3...4.11.4) #### What's Changed - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3124](https://togithub.com/tox-dev/tox/pull/3124) - Fix `quickstart` command from requiring `root` positional argument by [@​Tbruno25](https://togithub.com/Tbruno25) in [https://github.com/tox-dev/tox/pull/3123](https://togithub.com/tox-dev/tox/pull/3123) - docs(config): fix default value for install_command by [@​hashar](https://togithub.com/hashar) in [https://github.com/tox-dev/tox/pull/3126](https://togithub.com/tox-dev/tox/pull/3126) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3128](https://togithub.com/tox-dev/tox/pull/3128) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3132](https://togithub.com/tox-dev/tox/pull/3132) - Added Python 3.12 in installation docs by [@​mj0nez](https://togithub.com/mj0nez) in [https://github.com/tox-dev/tox/pull/3133](https://togithub.com/tox-dev/tox/pull/3133) - Fix terminal size in tox commands ([#​2999](https://togithub.com/tox-dev/tox/issues/2999)) by [@​ziima](https://togithub.com/ziima) in [https://github.com/tox-dev/tox/pull/3139](https://togithub.com/tox-dev/tox/pull/3139) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3135](https://togithub.com/tox-dev/tox/pull/3135) - Use the new ruff formatter over black by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3142](https://togithub.com/tox-dev/tox/pull/3142) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3147](https://togithub.com/tox-dev/tox/pull/3147) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3149](https://togithub.com/tox-dev/tox/pull/3149) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3154](https://togithub.com/tox-dev/tox/pull/3154) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3161](https://togithub.com/tox-dev/tox/pull/3161) - docs(config): Fix base_python default reference by [@​rpatterson](https://togithub.com/rpatterson) in [https://github.com/tox-dev/tox/pull/3156](https://togithub.com/tox-dev/tox/pull/3156) - Fixed 'AppData' not passed to env by default ([#​3151](https://togithub.com/tox-dev/tox/issues/3151)) by [@​Stefanhg](https://togithub.com/Stefanhg) in [https://github.com/tox-dev/tox/pull/3160](https://togithub.com/tox-dev/tox/pull/3160) #### New Contributors - [@​mj0nez](https://togithub.com/mj0nez) made their first contribution in [https://github.com/tox-dev/tox/pull/3133](https://togithub.com/tox-dev/tox/pull/3133) - [@​Stefanhg](https://togithub.com/Stefanhg) made their first contribution in [https://github.com/tox-dev/tox/pull/3160](https://togithub.com/tox-dev/tox/pull/3160) **Full Changelog**: tox-dev/tox@4.11.3...4.11.4 ### [`v4.11.3`](https://togithub.com/tox-dev/tox/releases/tag/4.11.3) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.11.2...4.11.3) #### What's Changed - docs(plugin): explain plugin registration by [@​hashar](https://togithub.com/hashar) in [https://github.com/tox-dev/tox/pull/3116](https://togithub.com/tox-dev/tox/pull/3116) - Fix error caused by a bad `base_python` path by [@​Tbruno25](https://togithub.com/Tbruno25) in [https://github.com/tox-dev/tox/pull/3122](https://togithub.com/tox-dev/tox/pull/3122) #### New Contributors - [@​hashar](https://togithub.com/hashar) made their first contribution in [https://github.com/tox-dev/tox/pull/3116](https://togithub.com/tox-dev/tox/pull/3116) **Full Changelog**: tox-dev/tox@4.11.2...4.11.3 ### [`v4.11.2`](https://togithub.com/tox-dev/tox/releases/tag/4.11.2) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.11.1...4.11.2) #### What's Changed - Fix typos discovered by codespell by [@​cclauss](https://togithub.com/cclauss) in [https://github.com/tox-dev/tox/pull/3113](https://togithub.com/tox-dev/tox/pull/3113) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tox-dev/tox/pull/3114](https://togithub.com/tox-dev/tox/pull/3114) - Providing example to make CLI help more helpful for -x,--override by [@​posita](https://togithub.com/posita) in [https://github.com/tox-dev/tox/pull/3119](https://togithub.com/tox-dev/tox/pull/3119) - Remove stray colons in `config.rst` left over from [#​3111](https://togithub.com/tox-dev/tox/issues/3111) by [@​posita](https://togithub.com/posita) in [https://github.com/tox-dev/tox/pull/3120](https://togithub.com/tox-dev/tox/pull/3120) #### New Contributors - [@​cclauss](https://togithub.com/cclauss) made their first contribution in [https://github.com/tox-dev/tox/pull/3113](https://togithub.com/tox-dev/tox/pull/3113) - [@​posita](https://togithub.com/posita) made their first contribution in [https://github.com/tox-dev/tox/pull/3119](https://togithub.com/tox-dev/tox/pull/3119) **Full Changelog**: tox-dev/tox@4.11.1...4.11.2 ### [`v4.11.1`](https://togithub.com/tox-dev/tox/releases/tag/4.11.1) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.11.0...4.11.1) #### What's Changed - Tests: Don't assume Python 3.10 is always installed, use current Python version by [@​hroncok](https://togithub.com/hroncok) in [https://github.com/tox-dev/tox/pull/3108](https://togithub.com/tox-dev/tox/pull/3108) - Set the --parallel default to "auto", not CPU count by [@​paravoid](https://togithub.com/paravoid) in [https://github.com/tox-dev/tox/pull/3109](https://togithub.com/tox-dev/tox/pull/3109) - Fix , being used as value parser for env var configs by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3111](https://togithub.com/tox-dev/tox/pull/3111) **Full Changelog**: tox-dev/tox@4.11.0...4.11.1 ### [`v4.11.0`](https://togithub.com/tox-dev/tox/releases/tag/4.11.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.10.0...4.11.0) #### What's Changed - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3102](https://togithub.com/tox-dev/tox/pull/3102) - Fix type checker and bump tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3107](https://togithub.com/tox-dev/tox/pull/3107) - Add config_settings support for build backend calls by [@​nschloe](https://togithub.com/nschloe) in [https://github.com/tox-dev/tox/pull/3090](https://togithub.com/tox-dev/tox/pull/3090) #### New Contributors - [@​nschloe](https://togithub.com/nschloe) made their first contribution in [https://github.com/tox-dev/tox/pull/3090](https://togithub.com/tox-dev/tox/pull/3090) **Full Changelog**: tox-dev/tox@4.10.0...4.11.0 ### [`v4.10.0`](https://togithub.com/tox-dev/tox/releases/tag/4.10.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.9.0...4.10.0) #### What's Changed - Set basepython for docs env in alignment to Read the Docs default by [@​jugmac00](https://togithub.com/jugmac00) in [https://github.com/tox-dev/tox/pull/3097](https://togithub.com/tox-dev/tox/pull/3097) - Document release process by [@​jugmac00](https://togithub.com/jugmac00) in [https://github.com/tox-dev/tox/pull/3094](https://togithub.com/tox-dev/tox/pull/3094) - Replace undefined settings with overrides when appending by [@​stefanor](https://togithub.com/stefanor) in [https://github.com/tox-dev/tox/pull/3101](https://togithub.com/tox-dev/tox/pull/3101) - Accept environments with defined factors or of python selector form - suggest closest by [@​BeyondEvil](https://togithub.com/BeyondEvil) in [https://github.com/tox-dev/tox/pull/3099](https://togithub.com/tox-dev/tox/pull/3099) #### New Contributors - [@​BeyondEvil](https://togithub.com/BeyondEvil) made their first contribution in [https://github.com/tox-dev/tox/pull/3099](https://togithub.com/tox-dev/tox/pull/3099) **Full Changelog**: tox-dev/tox@4.9.0...4.10.0 ### [`v4.9.0`](https://togithub.com/tox-dev/tox/releases/tag/4.9.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.8.0...4.9.0) #### What's Changed - Disallow command line environments which are not explicitly specified in the config file by [@​tjsmart](https://togithub.com/tjsmart) in [https://github.com/tox-dev/tox/pull/3089](https://togithub.com/tox-dev/tox/pull/3089) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3091](https://togithub.com/tox-dev/tox/pull/3091) #### New Contributors - [@​tjsmart](https://togithub.com/tjsmart) made their first contribution in [https://github.com/tox-dev/tox/pull/3089](https://togithub.com/tox-dev/tox/pull/3089) **Full Changelog**: tox-dev/tox@4.8.0...4.9.0 ### [`v4.8.0`](https://togithub.com/tox-dev/tox/releases/tag/4.8.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.7.0...4.8.0) #### What's Changed - Correct "notset" typo in --hashseed's --help text. by [@​lamby](https://togithub.com/lamby) in [https://github.com/tox-dev/tox/pull/3082](https://togithub.com/tox-dev/tox/pull/3082) - Bump pypa/gh-action-pypi-publish from 1.8.8 to 1.8.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tox-dev/tox/pull/3085](https://togithub.com/tox-dev/tox/pull/3085) - Allow extending lists with --override foo+=bar by [@​stefanor](https://togithub.com/stefanor) in [https://github.com/tox-dev/tox/pull/3088](https://togithub.com/tox-dev/tox/pull/3088) #### New Contributors - [@​lamby](https://togithub.com/lamby) made their first contribution in [https://github.com/tox-dev/tox/pull/3082](https://togithub.com/tox-dev/tox/pull/3082) - [@​stefanor](https://togithub.com/stefanor) made their first contribution in [https://github.com/tox-dev/tox/pull/3088](https://togithub.com/tox-dev/tox/pull/3088) **Full Changelog**: tox-dev/tox@4.7.0...4.8.0 ### [`v4.7.0`](https://togithub.com/tox-dev/tox/releases/tag/4.7.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.6.4...4.7.0) #### What's Changed - Fix doc alignment and link check by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3059](https://togithub.com/tox-dev/tox/pull/3059) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3061](https://togithub.com/tox-dev/tox/pull/3061) - Bump pypa/gh-action-pypi-publish from 1.8.7 to 1.8.8 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tox-dev/tox/pull/3063](https://togithub.com/tox-dev/tox/pull/3063) - Update a test regex to work with Python 3.12+ by [@​hroncok](https://togithub.com/hroncok) in [https://github.com/tox-dev/tox/pull/3066](https://togithub.com/tox-dev/tox/pull/3066) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3067](https://togithub.com/tox-dev/tox/pull/3067) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3070](https://togithub.com/tox-dev/tox/pull/3070) - Remove broken link by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3072](https://togithub.com/tox-dev/tox/pull/3072) - Add sponsor button for tidelift by [@​jugmac00](https://togithub.com/jugmac00) in [https://github.com/tox-dev/tox/pull/3079](https://togithub.com/tox-dev/tox/pull/3079) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3081](https://togithub.com/tox-dev/tox/pull/3081) - Make --hashseed default to PYTHONHASHSEED, if defined by [@​paravoid](https://togithub.com/paravoid) in [https://github.com/tox-dev/tox/pull/3076](https://togithub.com/tox-dev/tox/pull/3076) **Full Changelog**: tox-dev/tox@4.6.4...4.7.0 ### [`v4.6.4`](https://togithub.com/tox-dev/tox/releases/tag/4.6.4) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.6.3...4.6.4) #### What's Changed - Ensure tox r -e docs generates the documentation by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3047](https://togithub.com/tox-dev/tox/pull/3047) - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/tox-dev/tox/pull/3051](https://togithub.com/tox-dev/tox/pull/3051) - Bump pypa/gh-action-pypi-publish from 1.8.6 to 1.8.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tox-dev/tox/pull/3052](https://togithub.com/tox-dev/tox/pull/3052) - s/setup.cfg/pyproject.toml/ in the development docs by [@​sk1p](https://togithub.com/sk1p) in [https://github.com/tox-dev/tox/pull/3058](https://togithub.com/tox-dev/tox/pull/3058) - Fix hang and zombie process on interrupt (CTRL-C). by [@​sk1p](https://togithub.com/sk1p) in [https://github.com/tox-dev/tox/pull/3057](https://togithub.com/tox-dev/tox/pull/3057) **Full Changelog**: tox-dev/tox@4.6.3...4.6.4 ### [`v4.6.3`](https://togithub.com/tox-dev/tox/releases/tag/4.6.3) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.6.2...4.6.3) #### What's Changed - Made issue template have less whitespace by [@​jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/tox-dev/tox/pull/3038](https://togithub.com/tox-dev/tox/pull/3038) - Docs link of env var subs section to `set_env` by [@​jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/tox-dev/tox/pull/3039](https://togithub.com/tox-dev/tox/pull/3039) - Removed duplicate text in bug report template by [@​jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/tox-dev/tox/pull/3040](https://togithub.com/tox-dev/tox/pull/3040) - Ensure `get_requires*` hook is called before `prepare_metadata*` by [@​abravalheri](https://togithub.com/abravalheri) in [https://github.com/tox-dev/tox/pull/3044](https://togithub.com/tox-dev/tox/pull/3044) #### New Contributors - [@​jamesbraza](https://togithub.com/jamesbraza) made their first contribution in [https://github.com/tox-dev/tox/pull/3038](https://togithub.com/tox-dev/tox/pull/3038) - [@​abravalheri](https://togithub.com/abravalheri) made their first contribution in [https://github.com/tox-dev/tox/pull/3044](https://togithub.com/tox-dev/tox/pull/3044) **Full Changelog**: tox-dev/tox@4.6.2...4.6.3 ### [`v4.6.2`](https://togithub.com/tox-dev/tox/releases/tag/4.6.2) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.6.1...4.6.2) #### What's Changed - Avoid cache collision between wheel and editable wheel builds by [@​f3flight](https://togithub.com/f3flight) in [https://github.com/tox-dev/tox/pull/3035](https://togithub.com/tox-dev/tox/pull/3035) **Full Changelog**: tox-dev/tox@4.6.1...4.6.2 ### [`v4.6.1`](https://togithub.com/tox-dev/tox/releases/tag/4.6.1) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.6.0...4.6.1) #### What's Changed - Update `usedevelop` doc by referring to PEP-660. by [@​tibortakacs](https://togithub.com/tibortakacs) in [https://github.com/tox-dev/tox/pull/3025](https://togithub.com/tox-dev/tox/pull/3025) - Use ruff by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3033](https://togithub.com/tox-dev/tox/pull/3033) #### New Contributors - [@​tibortakacs](https://togithub.com/tibortakacs) made their first contribution in [https://github.com/tox-dev/tox/pull/3025](https://togithub.com/tox-dev/tox/pull/3025) **Full Changelog**: tox-dev/tox@4.6.0...4.6.1 ### [`v4.6.0`](https://togithub.com/tox-dev/tox/releases/tag/4.6.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.5.2...4.6.0) #### What's Changed - Remove unnecessary Future usage by [@​living180](https://togithub.com/living180) in [https://github.com/tox-dev/tox/pull/3020](https://togithub.com/tox-dev/tox/pull/3020) - Test against 3.12.0-beta.1 by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3022](https://togithub.com/tox-dev/tox/pull/3022) - Add --list-dependencies options by [@​lengau](https://togithub.com/lengau) in [https://github.com/tox-dev/tox/pull/3024](https://togithub.com/tox-dev/tox/pull/3024) #### New Contributors - [@​living180](https://togithub.com/living180) made their first contribution in [https://github.com/tox-dev/tox/pull/3020](https://togithub.com/tox-dev/tox/pull/3020) - [@​lengau](https://togithub.com/lengau) made their first contribution in [https://github.com/tox-dev/tox/pull/3024](https://togithub.com/tox-dev/tox/pull/3024) **Full Changelog**: tox-dev/tox@4.5.2...4.6.0 ### [`v4.5.2`](https://togithub.com/tox-dev/tox/releases/tag/4.5.2) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.5.1.1...4.5.2) #### What's Changed - Add 3.12 support by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/2998](https://togithub.com/tox-dev/tox/pull/2998) - Bump pypa/gh-action-pypi-publish from 1.8.5 to 1.8.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tox-dev/tox/pull/3003](https://togithub.com/tox-dev/tox/pull/3003) - Update list of maintainers by [@​jugmac00](https://togithub.com/jugmac00) in [https://github.com/tox-dev/tox/pull/3008](https://togithub.com/tox-dev/tox/pull/3008) - fix legacy `tox --devenv venv` by [@​asottile](https://togithub.com/asottile) in [https://github.com/tox-dev/tox/pull/3013](https://togithub.com/tox-dev/tox/pull/3013) - Fix legacy devenv by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3019](https://togithub.com/tox-dev/tox/pull/3019) **Full Changelog**: tox-dev/tox@4.5.1...4.5.2 ### [`v4.5.1.1`](https://togithub.com/tox-dev/tox/compare/4.5.1...4.5.1.1) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.5.1...4.5.1.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy42NC4yIiwidXBkYXRlZEluVmVyIjoiMzcuNjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found it! And because it took me 6 hours to debug it, I'm going to describe how the debugging went.
At first, I started debugging the tox itself. Quickly I managed to discover, the issue can be triggered by
python3 -c "from prompt_toolkit import prompt; prompt('Give me some input: ')"
which behaved differently in tox and outside. After couple of hours trying to navigate the tox internals I landed atReadViaThreadUnix
where I noticed it print a significant number of '\r\n' pairs after the prompt. That led me to theprompt_toolkit
. I spend some time there, until I discovered the screen it renders within tox has an unusual height. A but later I noticed the screen it tries to render have switched values of columns and rows when compared toCOLUMNS
andROWS
pass in env values by tox. Bit more digging lead toos.get_terminal_size()
. The MWE was now just simply:I had no idea what to do now, but I didn't want to give up. I realized I could just grep
tox
source code for columns and I finally found match in_pty
function. I tried to switch the two arguments and voila, works like a charm.This PR is not yet finished, I haven't found how to design a test for this and I'm too tired at the moment. I hope to add it soon.
tox -e fix
)docs/changelog
folderupdated/extended the documentation