Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-path returned from _path methods on MacOS #299

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Fix multi-path returned from _path methods on MacOS #299

merged 2 commits into from
Sep 8, 2024

Conversation

matthewhughes934
Copy link
Contributor

Fix site_{data,cache}_path returning pathlib.Path based on the entire : separated multipath under Homebrew with multipath enabled. Instead, follow the approach used by Unix and only return the first element if we're multipath

These were the only two attributes that changed when under homebrew

Issue: 292

@matthewhughes934 matthewhughes934 mentioned this pull request Sep 8, 2024
Closed
gaborbernat
gaborbernat previously approved these changes Sep 8, 2024
View reviewed changes
@gaborbernat gaborbernat enabled auto-merge (squash) September 8, 2024 13:30
@matthewhughes934
Fix multi-path returned from _path methods on MacOS
e2959b5 
Fix `site_{data,cache}_path` returning `pathlib.Path` based on the
entire `:` separated multipath under Homebrew with `multipath` enabled.
Instead, follow the approach used by `Unix` and only return the first
element if we're `multipath`

These were the only two attributes that changed when under `homebrew`

Issue: 292
auto-merge was automatically disabled September 8, 2024 14:16

Head branch was pushed to by a user without write access

@matthewhughes934 matthewhughes934 force-pushed the fix-macos-multipath-path-attributes branch from 9c77dcd to e2959b5 Compare September 8, 2024 14:16
@gaborbernat gaborbernat enabled auto-merge (squash) September 8, 2024 14:46
@gaborbernat gaborbernat merged commit c596271 into tox-dev:main Sep 8, 2024
31 checks passed
ldetmer referenced this pull request in googleapis/sdk-platform-java Sep 9, 2024
@renovate-bot
deps: update dependency platformdirs to v4.3.2 (#3176)
4f2f9e0 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://redirect.github.com/platformdirs/platformdirs)
| `==4.2.2` -> `==4.3.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.3.2`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.2)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.1...4.3.2)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Use uv as installer by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[https://github.com/tox-dev/platformdirs/pull/300](https://redirect.github.com/tox-dev/platformdirs/pull/300)
- Fix multi-path returned from `_path` methods on MacOS by
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
in
[https://github.com/tox-dev/platformdirs/pull/299](https://redirect.github.com/tox-dev/platformdirs/pull/299)

#### New Contributors

-
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
made their first contribution in
[https://github.com/tox-dev/platformdirs/pull/299](https://redirect.github.com/tox-dev/platformdirs/pull/299)

**Full Changelog**:
tox-dev/platformdirs@4.3.1...4.3.2

###
[`v4.3.1`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.1)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.0...4.3.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

**Full Changelog**:
tox-dev/platformdirs@4.3.0...4.3.1

###
[`v4.3.0`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.0)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.2.2...4.3.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Speed up Hatch installation by
[@&#8203;ofek](https://redirect.github.com/ofek) in
[https://github.com/tox-dev/platformdirs/pull/282](https://redirect.github.com/tox-dev/platformdirs/pull/282)
- Test with Python 3.13 by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[https://github.com/tox-dev/platformdirs/pull/289](https://redirect.github.com/tox-dev/platformdirs/pull/289)
- Test with latest PyPy by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[https://github.com/tox-dev/platformdirs/pull/290](https://redirect.github.com/tox-dev/platformdirs/pull/290)
- Use `include-hidden-files: true` to upload coverage artifacts by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[https://github.com/tox-dev/platformdirs/pull/298](https://redirect.github.com/tox-dev/platformdirs/pull/298)
- Ensure PlatformDirs is valid superclass type for mypy AND not an
abstract class for other checkers by
[@&#8203;Avasam](https://redirect.github.com/Avasam) in
[https://github.com/tox-dev/platformdirs/pull/295](https://redirect.github.com/tox-dev/platformdirs/pull/295)

#### New Contributors

- [@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
made their first contribution in
[https://github.com/tox-dev/platformdirs/pull/289](https://redirect.github.com/tox-dev/platformdirs/pull/289)
- [@&#8203;Avasam](https://redirect.github.com/Avasam) made their first
contribution in
[https://github.com/tox-dev/platformdirs/pull/295](https://redirect.github.com/tox-dev/platformdirs/pull/295)

**Full Changelog**:
tox-dev/platformdirs@4.2.2...4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
ldetmer referenced this pull request in googleapis/sdk-platform-java Sep 17, 2024
@renovate-bot @ldetmer
deps: update dependency platformdirs to v4.3.2 (#3176)
0327f1c 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://redirect.github.com/platformdirs/platformdirs)
| `==4.2.2` -> `==4.3.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.2.2/4.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.3.2`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.2)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.1...4.3.2)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Use uv as installer by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[https://github.com/tox-dev/platformdirs/pull/300](https://redirect.github.com/tox-dev/platformdirs/pull/300)
- Fix multi-path returned from `_path` methods on MacOS by
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
in
[https://github.com/tox-dev/platformdirs/pull/299](https://redirect.github.com/tox-dev/platformdirs/pull/299)

#### New Contributors

-
[@&#8203;matthewhughes934](https://redirect.github.com/matthewhughes934)
made their first contribution in
[https://github.com/tox-dev/platformdirs/pull/299](https://redirect.github.com/tox-dev/platformdirs/pull/299)

**Full Changelog**:
tox-dev/platformdirs@4.3.1...4.3.2

###
[`v4.3.1`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.1)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.0...4.3.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

**Full Changelog**:
tox-dev/platformdirs@4.3.0...4.3.1

###
[`v4.3.0`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.0)

[Compare
Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.2.2...4.3.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Speed up Hatch installation by
[@&#8203;ofek](https://redirect.github.com/ofek) in
[https://github.com/tox-dev/platformdirs/pull/282](https://redirect.github.com/tox-dev/platformdirs/pull/282)
- Test with Python 3.13 by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[https://github.com/tox-dev/platformdirs/pull/289](https://redirect.github.com/tox-dev/platformdirs/pull/289)
- Test with latest PyPy by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[https://github.com/tox-dev/platformdirs/pull/290](https://redirect.github.com/tox-dev/platformdirs/pull/290)
- Use `include-hidden-files: true` to upload coverage artifacts by
[@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
in
[https://github.com/tox-dev/platformdirs/pull/298](https://redirect.github.com/tox-dev/platformdirs/pull/298)
- Ensure PlatformDirs is valid superclass type for mypy AND not an
abstract class for other checkers by
[@&#8203;Avasam](https://redirect.github.com/Avasam) in
[https://github.com/tox-dev/platformdirs/pull/295](https://redirect.github.com/tox-dev/platformdirs/pull/295)

#### New Contributors

- [@&#8203;edgarrmondragon](https://redirect.github.com/edgarrmondragon)
made their first contribution in
[https://github.com/tox-dev/platformdirs/pull/289](https://redirect.github.com/tox-dev/platformdirs/pull/289)
- [@&#8203;Avasam](https://redirect.github.com/Avasam) made their first
contribution in
[https://github.com/tox-dev/platformdirs/pull/295](https://redirect.github.com/tox-dev/platformdirs/pull/295)

**Full Changelog**:
tox-dev/platformdirs@4.2.2...4.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
@matthewhughes934 matthewhughes934 deleted the fix-macos-multipath-path-attributes branch October 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@ofek ofek Awaiting requested review from ofek ofek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewhughes934 @gaborbernat