-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(@toss/emotion-utils): update resetButton to resetList #495
Open
dep-official
wants to merge
394
commits into
toss:add-gitattributes
Choose a base branch
from
dep-official:feat/resetList-docs-update
base: add-gitattributes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs(@toss/emotion-utils): update resetButton to resetList #495
dep-official
wants to merge
394
commits into
toss:add-gitattributes
from
dep-official:feat/resetList-docs-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yGroup (toss#181) * docs(error-boundary): add description of ErrorBoundaryGroup * docs(error-boundary): add english version description of ErrorBoundaryGroup Co-authored-by: Sojin Park <[email protected]>
…in value (toss#185) * fix(utils): Fix clamp return wrong value when value is smaller than min value * fix: fix another test case when max value is null * fix: fix test case description * Revert "fix(utils): Fix clamp return wrong value when value is smaller than min value" This reverts commit b1bfc08. * docs: fix ko, en clamp docs
* docs(js-docs): improve js-doc comments * docs(error-boundary): add example to reset ErrorBoundary
…roup` (toss#182) Co-authored-by: Sojin Park <[email protected]>
- [email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected]
…eryResultOnIdle (toss#186) * fix(react-query): remove chance to use generic of SuspendedUseQueryResultOnIdle * fix(react-query): remove unnecessary using generic
…set correctly (toss#178) * fix(error-boundary): connect RenderFallbackProps.reset's args to onReset * fix(error-boundary): remove feature of ErrorBoundary's reset passing args to onReset
Co-authored-by: Sojin Park <[email protected]>
Co-authored-by: Jisoo <[email protected]> Co-authored-by: Sojin Park <[email protected]>
- @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected]
Co-authored-by: chanhyukpark-29cm <[email protected]>
…displayName in development mode (toss#195) * feat(withAsyncBoundary): add withAsyncBoundary's display for development mode * feat(error-boundary): add withErrorBoundary like withAsyncBoundary of @toss/async-boundary * fix(async-boundary, error-boundary): change Unknown into Component
Co-authored-by: Sojin Park <[email protected]>
…s#199) * fix(react): remove useless fragment tag * feat(@toss/emotion-utils): write test code for coerceCssPixelValue Co-authored-by: chanhyukpark-29cm <[email protected]> Co-authored-by: Sojin Park <[email protected]>
* refactor(error-boundary): improve consistency of package * fix(error-boundary): translate Korean testing code to English * chore(error-boundary): remove useless isDevelopment * fix(error-boundary): add displayName of ErrorBoundary
…op (toss#201) Co-authored-by: Sojin Park <[email protected]>
* refactor(react): Change how return type is specified * docs(react): useForceUpdate note fix * docs: useForceUpdate jsdoc @link Co-authored-by: Jonghyeon Ko <[email protected]> --------- Co-authored-by: Jonghyeon Ko <[email protected]> Co-authored-by: Sojin Park <[email protected]>
Co-authored-by: Sojin Park <[email protected]>
…` method (toss#208) * fix(react): remove useless fragment tag * feat(@toss/emotion-utils): write test code for coerceCssPixelValue * fix(@toss/storage) modify test key of clear method --------- Co-authored-by: chanhyukpark-29cm <[email protected]> Co-authored-by: Sojin Park <[email protected]>
* fix(react): remove useless fragment tag * feat(@toss/emotion-utils): write test code for coerceCssPixelValue * fix(@toss/storage) remove duplicated test case --------- Co-authored-by: chanhyukpark-29cm <[email protected]> Co-authored-by: Sojin Park <[email protected]> Co-authored-by: Hoseung <[email protected]>
…orage. (toss#209) * fix(react): remove useless fragment tag * feat(@toss/emotion-utils): write test code for coerceCssPixelValue * fix(@toss/storage) modify test key of clear method * feat(@toss/storage): increase, decrease method can accept offset argument * docs(@toss/storage): write test code for adding offset argument * feat: specified the type of offset * fix: test description more sophisticated --------- Co-authored-by: chanhyukpark-29cm <[email protected]> Co-authored-by: Sojin Park <[email protected]>
* fix * fix * fix * fix * fix
* docs(README.md): add gif animation banner * fix(README.md): change file extension from gif to png
…Effect order to improve readability, add dependencies (toss#481) Co-authored-by: 박찬혁 <[email protected]>
…oss#462) Co-authored-by: Jonghyeon Ko <[email protected]>
… because of isMounted's side effect (toss#287)
…ss#259) * refactor(emotion-utils): remove useless import statemenet * fix(react-query): modify docs * test(utils): wrote test code for getViewportsize --------- Co-authored-by: Sojin Park <[email protected]>
…toss#464) Co-authored-by: Sojin Park <[email protected]>
…geState (toss#478) * fix synchronization issue * add test * remove test title typo
Co-authored-by: Sojin Park <[email protected]>
… keep add and remove eventlistener (toss#453) * fix: add callback dependency on useOutsideClickEffect using preservedCallback * fix: delete touchstart event from `useOutsideClickEffect` * Revert "fix: delete touchstart event from `useOutsideClickEffect`" This reverts commit c1b09c9. * fix(@toss/validators): Increase the accuracy of verification for isBirthDate6 (toss#420) * fix(@toss/validators): Increase the accuracy of verification * test(@toss/validators): add test case * fix: catch 2000y bug * refactor: change from magic number to constant variable * test: split test case * refactor: change constant variable name * refactor(@toss/validators): use proper library(date-fns) * chore(release): Publish libraries [skip ci] - @toss/[email protected] - [email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] - @toss/[email protected] * Revert "chore(release): Publish libraries [skip ci]" This reverts commit c325c90. * Revert "fix(@toss/validators): Increase the accuracy of verification for isBirthDate6 (toss#420)" This reverts commit 2565f17. * Apply suggestions from code review --------- Co-authored-by: Dongkyu Kim <[email protected]> Co-authored-by: raon0211 <[email protected]> Co-authored-by: Sojin Park <[email protected]>
…g function. (toss#455) * docs(@toss/utils): translate queryString comments to English * docs(@toss/utils): translate queryString test code to English * fix(@toss/utils): use QS module for queryString function calls * test(@toss/utils): add QS.get test cases for queryString --------- Co-authored-by: Sojin Park <[email protected]>
…ronment (toss#459) Co-authored-by: Sojin Park <[email protected]>
…parsing (toss#458) * test(@toss/utils): add isHexToRgba test code * test(@toss/utils): add isHexToRgba test code * fix(@toss/utils): correct hex validation to prevent unexpected color parsing * fix(@toss/utils): correct typo * test(@toss/utils): reorganize hex validation tests for clarity * test(@toss/utils): adjust tests for hex value formats, remove Korean comments * refactor(@toss/utils): improve hexToRgba function clarity using regex --------- Co-authored-by: Sojin Park <[email protected]>
* fix(use-funnel) : model에 NonEmptyArray 변경 * fix(use-funnel) : 기존에 NonEmptyArray타입이 사용되던 곳에 StepsType으로 변경
* test: add useSuspendedInfiniteQuery test * feat: add useSuspendedInfiniteQuery hook * docs: add useSuspendedInfiniteQuery docs * feat: omit status option * style: change export order
…lescing operator (`??`) (toss#487) * fix(@toss/hangul): replace non-null assertion(!) with nullish coalescing operator (??) * Revert "fix(@toss/hangul): replace non-null assertion(!) with nullish coalescing operator (??)" This reverts commit ad30a84. * fix(@toss/hangul): Add eslint-disable for no-non-null-assertion warning --------- Co-authored-by: Sojin Park <[email protected]>
…modified `useLoading` to avoid state updates when the component is unmounted (toss#296) * feat: Modify useLoading to avoid state updates when the component is unmounted * feat: impletmenet useIMountedRef * docs: write --------- Co-authored-by: raon0211 <[email protected]>
* feat: stop, resume, intervalRunning State * fix: change to use the enable option rather than useState * feat: not register when enabled is false
* docs: useInterval korean docs fix typo * docs: unification of the expression of an English docs
@dep-official is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR Checklist