-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Django < 4.2, Python < 3.10 and fix old mock paths #51
Conversation
9e1e0ec
to
b280ec4
Compare
b280ec4
to
305c80e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works.
I added a note and a non-blocking suggestion
There's something funny with py 3.8/3.9. It errors with it loads boto==2.49.0,boto3==1.7.84,botocore==1.10.84,s3transfer==0.1.13 boto3 is at 1.35.x upd: on 3.10 it loads "boto3==1.35.20,botocore==1.35.20,s3transfer==0.10.2" I suggest dropping Python 3.8 as support for it ends in a month - https://endoflife.date/python, and bump min s3transfer and or boto3 versions in testing |
@zerolab Yeah, have been wrangling with this... It seems the easiest way is to drop 3.8 and 3.9. Looks like boto3 moves fast... No one would want to be on modern Django, Wagtail, and old Python. I'd rather not release a broken package to the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small detail and this is good to go!
Nice one on requiring a minimum of Python 3.10 💪🏼
it seems that it's urllib3 dependency breaking 3.8 and 3.9. |
A little tidy up after #50.