-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define additional interfaces via graphql_interfaces
#366
Conversation
2cbb66d
to
c4e82e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've Reviewed and tested this locally, just a few nickpicks around the documentation mainly
@@ -9,84 +9,6 @@ detail below. | |||
An existing understanding of GraphQL types will help here. | |||
|
|||
|
|||
PageInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job moving this!
@@ -229,7 +151,7 @@ You can also query a setting by model name: | |||
|
|||
.. code-block:: graphql | |||
|
|||
{ | |||
query { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question any reason not to include this change on line 140 above, too? There are also other query examples in decorators.rst
and model-types.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed one or two 🙈 Will address and go with a fine comb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be all sorted in 10acaf2
c4e82e3
to
10acaf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API to specify interfaces makes more sense than my decorator patch, and I think the code and docs improvements are spot on. I just have a nitpick about lists vs tuples. Can't wait to have this released :)
10acaf2
to
e599003
Compare
This allows defining additional interfaces on your models via the
graphql_interfaces
attribute.Also does a tiny bit of tidy-up in docs, but not too much. New docs page: https://wagtail-grapple--366.org.readthedocs.build/en/366/general-usage/interfaces.html