chore: re-organize test app #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dopry
commented
May 12, 2023
dopry
commented
- move example to test/testapp
- consolidate tests in one location
dopry
force-pushed
the
chore/reorg-tests
branch
14 times, most recently
from
b19e554 to
2c83b3f
Compare
Closed
|
@zerolab I'd love to get this in pronto so we're not blocking other PRs that may be implementing tests. I know we've requested tests on a few open PRs. |
zerolab
reviewed
May 12, 2023
zerolab
requested changes
May 12, 2023
|
@dopry did a quick first pass and left a couple of notes |
- move example to test/testapp - consolidate tests in one location
|
@zerolab I think I've addressed all the issues. This should be ready to review again. |
zerolab
reviewed
May 12, 2023
Co-authored-by: Dan Braghis <[email protected]>
zerolab
approved these changes
May 13, 2023
|
Let's get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.