Drop support for Wagtail < 4.1 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
force-pushed
the
wagtail-4.1-onwards
branch
3 times, most recently
from
3753d34 to
943eb85
Compare
zerolab
force-pushed
the
wagtail-4.1-onwards
branch
from
aa903bc to
8085d79
Compare
dopry
reviewed
Feb 13, 2023
| - python-version: '3.11' | ||
| wagtail-version: 'main' | ||
| allowfail: true |
There was a problem hiding this comment.
I dig this allow-fail setup. I may need to consider for some other projects.
There was a problem hiding this comment.
got that idea from actions/runner#2347
the UI will still be clunky (is it shows a red x like other fails).
I aim to move this to a nightly job as part of #289
There was a problem hiding this comment.
Cool.. I like having the canary for upcoming releases... but I think I'm in agreement wrt not wanting the big red x against unreleased code to be a distraction.
engAmirEng
pushed a commit
to engAmirEng/wagtail-grapple
that referenced
this pull request
May 2, 2023
* Change to support Wagtail 4.1+ and Python 3.8+ * Drop pre-4.1 shims * Remove unused code * Update CI * Use python 3.10 for RTD https://docs.readthedocs.io/en/stable/tutorial/index.html#upgrading-the-python-version https://docs.readthedocs.io/en/stable/config-file/v2.html#python * Update docs theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.1 is the latest LTS.
With 4.2 out, 2.15 (the previous LTS) no longer receives updates.
Time to tidy up. While at it, dropped Python 3.7 support