-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Wagtail v2.14 #172
Support Wagtail v2.14 #172
Conversation
Thank you @fabienheureux fwiw, I' would rather spend a bit more time and do this change properly (as outlined in https://docs.wagtail.io/en/stable/releases/2.12.html#stream-data-on-streamfield-values-is-deprecated) |
I have a question about this conditionnal: https://github.com/GrappleGQL/wagtail-grapple/blob/main/grapple/types/streamfield.py#L111 @zerolab do you have an idea of a query (in the example project) that could go through this conditionnal ? {
pages {
... on BlogPage {
body {
...on StreamFieldInterface {
rawValue
}
}
}
}
} And can't go through. I will continue digging this but maybe you have an idea. |
I use this PR on an actively developped project (wagtail 2.13) and I did not encounter any issues yet. Does anyone have a project, using wagtail < 2.13 on which it could be tested ? |
86a6a4f
to
e70d7b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fabienheureux,
a couple of minor tweaks and we can get it in and do a release candidate
Co-authored-by: Dan Braghis <[email protected]>
Co-authored-by: Dan Braghis <[email protected]>
Co-authored-by: Dan Braghis <[email protected]>
Co-authored-by: Dan Braghis <[email protected]>
This reverts commit 2d8ff44.
Thanks a lot for the suggestions ! |
@zerolab, @ruisaraiva19, when will this change be released, sorry? I'm seeing the following dependency definition in
So this is preventing Wagtail 2.14 from being installed because of conflicting dependencies, right? |
No changes seem to be required from Wagtail 2.13 release notes: https://docs.wagtail.io/en/stable/releases/2.13.html#updated-handling-of-non-required-streamfields
However, I noticed that
stream_data
was deprecated in 2.12, whereas 2.12 is a valid requirement for Grapple.I blindly replaced
stream_data
byraw_data
as suggested in the 2.12 release notes (https://docs.wagtail.io/en/stable/releases/2.12.html), however I would like to have a second pair of eyes here.Tests pass at the moment.