-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: custom document model not working with wagtail grapple #153
Merged
zerolab
merged 13 commits into
torchbox:main
from
fabienheureux:fix/custom-document-model
Apr 1, 2021
Merged
Fix: custom document model not working with wagtail grapple #153
zerolab
merged 13 commits into
torchbox:main
from
fabienheureux:fix/custom-document-model
Apr 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienheureux
changed the title
Fix custom document not working with wagtail grapple
[WIP] Fix custom document not working with wagtail grapple
Feb 4, 2021
This reverts commit be07454.
fabienheureux
changed the title
[WIP] Fix custom document not working with wagtail grapple
Fix custom document not working with wagtail grapple
Feb 6, 2021
fabienheureux
commented
Feb 6, 2021
fabienheureux
changed the title
Fix custom document not working with wagtail grapple
Fix custom document model not working with wagtail grapple
Feb 7, 2021
fabienheureux
changed the title
Fix custom document model not working with wagtail grapple
Fix: custom document model not working with wagtail grapple
Feb 7, 2021
@fabienheureux another omission in tests! Can you add a test to confirm your custom doc model is picked up? |
fabienheureux
changed the title
Fix: custom document model not working with wagtail grapple
[WIP] Fix: custom document model not working with wagtail grapple
Feb 9, 2021
fabienheureux
changed the title
[WIP] Fix: custom document model not working with wagtail grapple
Fix: custom document model not working with wagtail grapple
Apr 1, 2021
@zerolab I updated the code a bit to make the document type file look closer to the image type file. And I added a test 😅 (sorry for the delay.....). |
Thank you @fabienheureux, merged with a tweak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of Grapple does not seem to work with custom document model.
This fixes it
Edit: I added a custom document model in the example project in order to ensure that a custom document model works with Grapple.
Sorry for all the commits, this is the first time I worked with the example project and a few things went wrong because I did not install pre-commit hooks 😅
Also: I had to port this fix in order to fix example project tests: https://github.com/wagtail/wagtail/pull/6559/files
Let me know if I should rather fix this in another PR.