Fix: Occasional IntegrityError when saving 'new' assets #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
force-pushed
the
feature/clash-detection
branch
4 times, most recently
from
1f8510d to
64e471a
Compare
ababic
changed the title
ababic
force-pushed
the
feature/clash-detection
branch
8 times, most recently
from
4b245f8 to
b2956b4
Compare
ababic
force-pushed
the
feature/clash-detection
branch
11 times, most recently
from
c5ffb58 to
961e6fd
Compare
…ding the file to storage and saving
ababic
force-pushed
the
feature/clash-detection
branch
from
961e6fd to
11806c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading asset files can take a while, especially if Bynder is under strain or the connection to Bynder is poor. If multiple editors are working in Wagtail at once and happen choose the same (new) asset at around the same time, they unknowingly take part in a little race: The first request to finish downloading the file and saving the object will succeed, but the other will fail with an
IntegrityErrorbecause, by the time it tries to write to the DB, an object with the samebynder_idalready exists.A similar issue can also occur whilst saving the object, because it can take a while to copy the file from memory to media storage (which happens before attempting to save to the database). So, we need to account for
IntegrityErrorbeing raised at that later stage also. And ensure the newly-transferred redundant file is deleted from storage.