-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to navigate the menu with the keyboard. Fix #202 #207
Merged
thibaudcolas
merged 12 commits into
torchbox:main
from
chris-lawton:fix/202-menu-accessibility
Aug 19, 2023
Merged
Make it possible to navigate the menu with the keyboard. Fix #202 #207
thibaudcolas
merged 12 commits into
torchbox:main
from
chris-lawton:fix/202-menu-accessibility
Aug 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he icon can be clicked
chris-lawton
force-pushed
the
fix/202-menu-accessibility
branch
from
January 3, 2023 16:13
e910cde
to
3806680
Compare
ruteckimikolaj
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be merged. Fix and tests are present.
thibaudcolas
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUCH better! Thank you @chris-lawton
thibaudcolas
changed the title
Improve menu accessibility
Make it possible to navigate the menu with the keyboard. Fix #202
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the pattern library uses the menu item heading tags to listen for events which open and close their child menus. This is not accessible for users who navigate via keyboard only.
This MR resolves that by changing the menu item elements to buttons. In turn it also resolves #202.
It also:
.sidebar
to a new element.sidebar__inner
as when the sidebar is collapsed the padding meant the elements within the sidebar were still visible.whitelist_externals
is replaced byallowlist_externals
- https://tox.wiki/en/latest/changelog.html#deprecations-and-removals-4-0-0rc4Fixes #202
Checklist