Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to navigate the menu with the keyboard. Fix #202 #207

Merged
merged 12 commits into from
Aug 19, 2023

Conversation

chris-lawton
Copy link
Member

@chris-lawton chris-lawton commented Oct 31, 2022

Description

Currently the pattern library uses the menu item heading tags to listen for events which open and close their child menus. This is not accessible for users who navigate via keyboard only.

This MR resolves that by changing the menu item elements to buttons. In turn it also resolves #202.

It also:

Fixes #202

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@chris-lawton chris-lawton force-pushed the fix/202-menu-accessibility branch from e910cde to 3806680 Compare January 3, 2023 16:13
Copy link

@ruteckimikolaj ruteckimikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be merged. Fix and tests are present.

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUCH better! Thank you @chris-lawton

@thibaudcolas thibaudcolas changed the title Improve menu accessibility Make it possible to navigate the menu with the keyboard. Fix #202 Aug 19, 2023
@thibaudcolas thibaudcolas merged commit a330dd6 into torchbox:main Aug 19, 2023
@chris-lawton chris-lawton deleted the fix/202-menu-accessibility branch December 15, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the menu chevron should expand/collapse the menu
3 participants