-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API endpoint for pattern rendering via POST #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some subtle things that need changing in render_pattern()
, and it would also be good to see some tests that call the API and check this is functioning as intended, but this look 95% good to me.
a0e23e7
to
36fbd49
Compare
d92dfee
to
513898d
Compare
513898d
to
0b316e6
Compare
Code changes from feedback: check. Tests: check. Docs: check! Re-running black and isort three times: check. |
Description
Addresses #104. This adds an API endpoint built into the pattern library, and changes how tag overrides are loaded. This is so they can be loaded from the API data, rather than always loading the YAML file.
I could use additional feedback on this before adding the tests.
Checklist
To test this:
Suggested CHANGELOG entry: