Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for is_pattern_library context variable. Fix #156 #167

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Dec 22, 2021

Description

Addresses #156. I’ve added docs as well as a small demo – for the actual implementation & tests it was just a matter of renaming the existing variable.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Suggested CHANGELOG entry:

## Added

- Add a way to customise rendering of a pattern with [`is_pattern_library`](https://torchbox.github.io/django-pattern-library/reference/api/#is_pattern_library) context variable ([#156](https://github.com/torchbox/django-pattern-library/issues/156), [#167](https://github.com/torchbox/django-pattern-library/pull/167)).

@thibaudcolas thibaudcolas added this to the Nice to have milestone Dec 22, 2021
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thibaudcolas thibaudcolas merged commit b38e834 into main Jan 6, 2022
@thibaudcolas thibaudcolas deleted the feature/156-is_pattern_library branch January 6, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change __pattern_library_view to is_pattern_library and make it an official "API"
2 participants