Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.0 #164

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Dec 21, 2021

Description

Depends on #163. Updates the project’s test suite and metadata to support Django 4.0. I’ve done some brief testing of the pattern library with this version and couldn’t spot anything off (aside from #166, but I believe that can be done separately).

We could also remove our testing for Django 3.0 and 3.1 at the same time since they’re not technically supported anymore.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Suggested CHANGELOG entry:

## Added

- Support Django 4.0 ([#164](https://github.com/torchbox/django-pattern-library/pull/164)).

@thibaudcolas thibaudcolas added enhancement New feature or request django Related to Django templates capabilities labels Dec 21, 2021
@thibaudcolas thibaudcolas added this to the Nice to have milestone Dec 21, 2021
@thibaudcolas thibaudcolas force-pushed the chore/python-versions branch 3 times, most recently from 8733716 to 533d679 Compare December 21, 2021 22:12
@thibaudcolas thibaudcolas marked this pull request as ready for review December 21, 2021 23:52
@thibaudcolas thibaudcolas modified the milestones: Nice to have, v1.0.0 Jan 19, 2022
Copy link

@bcdickinson bcdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM, thanks Thibaud!

@thibaudcolas thibaudcolas merged commit 3e0967e into chore/python-versions Jan 24, 2022
@thibaudcolas thibaudcolas deleted the chore/django-4.0 branch January 24, 2022 12:46
@thibaudcolas
Copy link
Member Author

Thank you @bcdickinson, I assume you’ve reviewed #163 which this depends on so will merge both now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Related to Django templates capabilities enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants