Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IE11 support. Fix #151 #162

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Remove IE11 support. Fix #151 #162

merged 3 commits into from
Jan 25, 2022

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Dec 21, 2021 •
edited
Loading

Description

Fixes #151. This fully removes support for IE11 in the pattern library UI, updating our browserslist to recent browsers as well.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works Not relevant
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Proposed CHANGELOG entry:

- Remove support for IE11 in pattern library UI ([#151](https://github.com/torchbox/django-pattern-library/issue/151), [#162](https://github.com/torchbox/django-pattern-library/pull/162)).

@thibaudcolas thibaudcolas added this to the Nice to have milestone Dec 21, 2021
@thibaudcolas thibaudcolas mentioned this pull request Dec 21, 2021
Closed
@thibaudcolas thibaudcolas force-pushed the chore/remove-ie11-support branch from d28def5 to be85429 Compare December 21, 2021 20:48
@thibaudcolas thibaudcolas modified the milestones: Nice to have, v1.0.0 Jan 19, 2022
@thibaudcolas
Copy link
Member Author

I believe this is safe enough to merge without further review since IE11 support is already broken – this PR is just code cleanup.

@thibaudcolas thibaudcolas merged commit ef93568 into main Jan 25, 2022
@thibaudcolas thibaudcolas deleted the chore/remove-ie11-support branch January 25, 2022 13:25
@thibaudcolas thibaudcolas removed the request for review from bcdickinson January 25, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
django-pattern-library v1.0.0 release
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Pattern library does not load CSS or JavaScript in IE11
1 participant
@thibaudcolas