Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default_app_config conditional #160

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Make default_app_config conditional #160

merged 2 commits into from
Dec 21, 2021

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Dec 21, 2021

Description

This adds a conditional around default_app_config in init.py

The result is when using Django >= 3.2 there are no longer deprecation warnings shown in the console. The warnings can be enabled with python -Wa manage.py check

Fixes # (159)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@nickmoreton nickmoreton marked this pull request as ready for review December 21, 2021 12:56
@thibaudcolas thibaudcolas self-requested a review December 21, 2021 13:12
@thibaudcolas thibaudcolas added the django Related to Django templates capabilities label Dec 21, 2021
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nickmoreton, looks great to me. I’ll just change the CHANGELOG entry to mention default_app_config as part of releasing.

@thibaudcolas thibaudcolas added this to the Nice to have milestone Dec 21, 2021
@thibaudcolas thibaudcolas merged commit aae69f3 into main Dec 21, 2021
@thibaudcolas thibaudcolas deleted the default-app-config branch December 21, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Related to Django templates capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'pattern_library' defines default_app_config default_app_config in __init__.py deprecated since Django 3.2
2 participants