Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and support for Django 3.2, and tentative tests and support for Django 4.0 #144

Merged
merged 3 commits into from
May 20, 2021

Conversation

thibaudcolas
Copy link
Member

Description

This updates our testing matrix to test in Django 3.2 across all Python versions, and in Django 4.0 across Python versions that are supported.

Django 4.0 removes the long-deprecated django.conf.urls, so I’ve also updated the urlpatterns to use the path and re_path replacements.

I chose not to have the Django 4.0 CI builds as experimental / allowed to fail, as it would require splitting the build into even more separate jobs which I’m not a fan of.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Copy link

@bcdickinson bcdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Thibaud

@thibaudcolas thibaudcolas merged commit 984aa52 into master May 20, 2021
@thibaudcolas thibaudcolas deleted the chore/django-support branch May 20, 2021 08:53
@thibaudcolas thibaudcolas added django Related to Django templates capabilities enhancement New feature or request labels May 20, 2021
@thibaudcolas thibaudcolas added this to the Nice to have milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Related to Django templates capabilities enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants