Magisk is not automatically reinstalled on LineageOS updates since 18.1

[christophehenry]

Device: OnePlus 5T
Android version: 11 (LineageOS 18.1)
Magisk version name: 23.0
Magisk version code: 23001

Following the suggestion here, I'm opening the issue to raise the concern that Magisk is not automatically reinstalled on LineageOS updates since 18.1.

This issue has persisted accross all Lineage's updates despite the presence of the 99-magisk.sh in /system/addon.d/. I also asked to Lineage's team if this was a known issue and their response was basically "Yeah, we don't care" which is disappointing.

I need Magisk for several app, including automated backups using Titanium and app isolation with AFWall+. I can't afford to run Android without it.

[gbschenkel]

This happens because OnePlus 5T doesn't have A/B partition. Each time a update is installed it will overwrite the Magisk modifications. For you be able to upgrade and maintain Magisk you will need patch the OTA. I didn't find a easy way.
I have and use the OnePlus 5 (cheeseburger) also same OS, and I reinstall Magisk after the OTA upgrade, using adb probably as you do.

[christophehenry]

I reinstall Magisk after the OTA upgrade, using adb probably as you

Yes, that's what I do.

I don't understand. People from LineageOS told me that GApps reinstall after updates through /system/addon.d/ worked correctly. How is it different from Magisk?

[Didgeridoohan]

IIRC the discussion on this ended with both LOS devs and John saying: "but I/we want it this way and that doesn't work with your way". Which means that it's unlikely to be fixed, ever...

I may be remembering that completely wrong though.

[t-aus-m]

This happens because OnePlus 5T doesn't have A/B partition.

That might be wrong. I have the same issues on my Fairphone 3, which is a A/B device.

[topjohnwu]

@osm0sis would you be able to take a look?

[osm0sis]

On my to-do to investigate already, just very little time at the moment. I'll see what I can work on when I'm off in a few weeks!

[christophehenry]

If I can be of any help, please tell me.

[ChenDanCMU]

Same issue here on a Mi MIX (lithium) LOS 18.1.

[gbschenkel]

This happens because OnePlus 5T doesn't have A/B partition.

That might be wrong. I have the same issues on my Fairphone 3, which is a A/B device.

Was the response I got at LineageOS channel on Libera.chat

[jasonl502]

Same issue. galaxy s10, official los 18.1

[coxackie]

Isn't the main problem this? It has nothing to do with A/B partitions - it is a problem whenever one uses lineage recovery (that does not support FBE decryption). There is even a fork recently created to deal with the fact gives /data access in addon.d.

[osm0sis]

Yep, might be that if they're using Lineage Recovery (which doesn't support decryption) on an A-only device, but if they're using a TWRP build with working decryption then could be something else.

On A/B devices data should always be decrypted (since you're booted to Android) for addon.d-v2 so that shouldn't be a problem.

Maybe @christophehenry can describe his setup a bit more.

[Iey4iej3]

To add: I don't have this issue myself, but I use TWRP and I install the updates manually in the recovery. However, it is unclear if it is due to Lineage Recovery "since 18.1", since the full-disk encryption was applied much earlier.

[coxackie]

@osm0sis granted, it could be one or the other; the fact is, there is a large basis of lineage users that faces this same issue due to lineage recovery, and it is a bit sad that they either have to do update manually every time, or now have to use a fork that will try to keep up with upstream. but, oh well, decisions are decisions.

[cocka11]

Device: OnePlus 5T
Android version: 11 (LineageOS 18.1)
Magisk version name: 23.0
Magisk version code: 23001

Following the suggestion here, I'm opening the issue to raise the concern that Magisk is not automatically reinstalled on LineageOS updates since 18.1.

This issue has persisted accross all Lineage's updates despite the presence of the 99-magisk.sh in /system/addon.d/. I also asked to Lineage's team if this was a known issue and their response was basically "Yeah, we don't care" which is disappointing.

I need Magisk for several app, including automated backups using Titanium and app isolation with AFWall+. I can't afford to run Android without it.

i am in xiaomi redmi 7 and use lineage recovery and i did not have any this problem during the update. 🤔

[christophehenry]

@osm0sis Yes, indeed, during 18.1 update, LineageOS was uncivil enough to replace TWRP by its own recovery (edit: I was told that there is a setting in the updates section to disable recovery flash). I could try to reflash TWRP. But then I'm afraid Lineage replaces it again on each major release or even minor since, from what I've heard, they decided to stop supporting TWRP?

[Iey4iej3]

@osm0sis Yes, indeed, during 18.1 update, LineageOS was uncivil enough to replace TWRP by its own recovery. I could try to reflash TWRP. But then I'm afraid Lineage replaces it again on each major release or even minor since, from what I've heard, they decided to stop supporting TWRP?

I don't know whether they decided to stop supporting TWRP, but you could disable System → Advanced → Updater → ⫶ → Preferences → Update recovery. I don't use OTA updates though.

[osm0sis]

If not in the updater I think there's a Developer Setting too for disabling Lineage Recovery flashing. Okay so technically that might make this issue invalid, but I'll still look into addon.d on a few devices to see what's up before closing. 😉

[christophehenry]

This is disappointing for LineageOS but I understand it's not up to you if this is confirmed. At least I have a fix I can test. You might want to add this in the documentation, though.

And thank you very much for your time on debugging this.

[osm0sis]

Yeah it's just a limitation of Lineage Recovery not supporting decrypting data. There were options/proposals for working around this by storing Magisk binaries in system with the addon.d scripts, but that's a bit ugly to have multiple copies of Magisk files around which could get out of sync, so John was never really interested in that solution.

[osm0sis]

Whoops, tapped by mistake. Still want to do the testing I mentioned above. 😅

[Iey4iej3]

There was a post above (#4655 (comment)) which indicated that it works on a Xiaomi device with Lineage Recovery. Seemingly one still needs to look into that.

[ARitz-Cracker]

@osm0sis Yes, indeed, during 18.1 update, LineageOS was uncivil enough to replace TWRP by its own recovery. I could try to reflash TWRP. But then I'm afraid Lineage replaces it again on each major release or even minor since, from what I've heard, they decided to stop supporting TWRP?

Hey there! I'm also running a OnePlus 5t with LineageOS. Just wanted to let you know that you can disable updating recovery in the OTA updates settings, and installing OTA updates using TWRP works fine for now!

Though it'll definitely be interesting if Magisk can survive updates in a way which does not require /data decryption

[osm0sis]

Can confirm Magisk's addon.d still working flawlessly on OP5T (addon.d), and OP6 and OP7Pro (addon.d-v2), all with latest Lineage 18.1 and latest TWRP for each. 👍

CC: @topjohnwu

[ARitz-Cracker]

Can confirm Magisk's addon.d still working flawlessly on OP5T (addon.d), and OP6 and OP7Pro (addon.d-v2), all with latest Lineage 18.1 and latest TWRP for each. 👍

CC: @topjohnwu

I assume that surviving updates without data decryption isn't something you wish to do, then?

[osm0sis]

#4655 (comment)

[malnvenshorn]

I'm experiencing this issue with TWRP as recovery on my Nexus 7. Might not only be related to the lack of data decryption?

[osm0sis]

I'm experiencing this issue with TWRP as recovery on my Nexus 7. Might not only be related to the lack of data decryption?

I have official Lineage flox on my N7 2013 and Magisk's addon.d works perfectly with TWRP.