Skip to content

Commit

Permalink
requirements: Bump required tasklib version
Browse files Browse the repository at this point in the history
  • Loading branch information
tbabej committed Sep 18, 2020
1 parent a9af182 commit 5032d0d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
tasklib>=1.3,<2.0
tasklib>=2.2.1
2 changes: 1 addition & 1 deletion taskwiki/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ def enforce_dependencies(cache):
# Vim version is already checked in vimscript file
# This is done so that we avoid problems with +python

TASKLIB_VERSION = '0.10.0'
TASKLIB_VERSION = '2.2.1'
TASKWARRIOR_VERSION = '2.4.0'

# Check tasklib version
Expand Down

2 comments on commit 5032d0d

@liskin
Copy link
Collaborator

@liskin liskin commented on 5032d0d Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to break compatibility with older tasklib versions (and thus force users to use pip instead of letting the distro package manager do it properly and sustainably)? Are there any significant benefits?

@roosemberth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

I am unable to use taskwiki precisely because of this. I'm running NixOS 20.03 and the last packaged version is 1.3.0. Unfortunatelly I'm unable to use pip in my setup.
I tried pulling from NixOS 20.09 (alpha) and it only has version 2.2.0 (and has not yet been released).

Please sign in to comment.